Bug 1134545

Summary: Missing quota tables for Cisco N1KV monolithic plugin
Product: Red Hat OpenStack Reporter: Abhishek Raut <abhraut>
Component: openstack-neutronAssignee: Steven Hillman <sthillma>
Status: CLOSED ERRATA QA Contact: Ofer Blaut <oblaut>
Severity: high Docs Contact:
Priority: high    
Version: 5.0 (RHEL 7)CC: abhraut, chrisw, dontu, ihrachys, jhoffer, jlibosva, lpeer, morazi, nyechiel, sclewis, sgordon, tdunnon, tfreger, yeylon
Target Milestone: z2Keywords: OtherQA, ZStream
Target Release: 5.0 (RHEL 7)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: n1kv
Fixed In Version: openstack-neutron-2014.1.3-7.el6ost openstack-neutron-2014.1.3-6.el7ost Doc Type: Bug Fix
Doc Text:
Cause: Quota tables are not being generated for N1kV plugin. Consequence: Quota tables are not present when Cisco N1KV plugin is loaded with neutron and VM bringup fails. Fix: Add quotas table to the supported extensions for N1kV and fix folsom_initial to create quotas tables for plugins which support it. Result: VM bringup succeeds with the quotas tables present.
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-11-03 08:38:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1154145, 1154159    
Attachments:
Description Flags
Email thread none

Description Abhishek Raut 2014-08-27 18:21:07 UTC
Description of problem:

Quota tables are not present when Cisco N1KV plugin is loaded with neutron.
Missing quota tables affected multiple such plugins and cisco N1KV plugin is one of them. The bug was resolved upstream by the community. Reference bug id 1207402.

Comment 1 dontu 2014-08-27 18:28:04 UTC
Created attachment 931648 [details]
Email thread

Email thread between Cisco and RedHat on this issue

Comment 3 lpeer 2014-09-10 12:13:25 UTC
From a thread on the cisco list, the relevant part is -

https://review.openstack.org/#/c/40296/32/neutron/db/migration/alembic_migrations/common_ext_ops.py

Abhishek Raut -

Can you please confirm this is the only thing that is needed.
Can we please get a link to the u/s patch in stable Icehouse so we can cherry-pick it to the product.

Comment 4 Abhishek Raut 2014-09-10 18:45:47 UTC
In addition to the above fix, the following two changes also need to be ported for the fix to work.

https://review.openstack.org/#/c/40296/32/neutron/db/migration/alembic_migrations/versions/folsom_initial.py

https://review.openstack.org/#/c/51991/1/neutron/plugins/cisco/n1kv/n1kv_neutron_plugin.py


This bug has not been ported to stable/icehouse because it is a part of a big database cleanup change (https://bugs.launchpad.net/neutron/+bug/1207402) which will not be backported in stable/icehouse.

But for quota table to be populated in database for stable/icehouse we need the above three changes.
One option is to open up a bug against stable/icehouse branch and fix it there and then cherrypick it to the product.

Comment 5 lpeer 2014-09-11 05:50:06 UTC
(In reply to Abhishek Raut from comment #4)
> 
> But for quota table to be populated in database for stable/icehouse we need
> the above three changes.
> One option is to open up a bug against stable/icehouse branch and fix it
> there and then cherrypick it to the product.

That would be a very good path to take.

Please update this bug when you report the bug against stable/Icehouse and send a patch which includes all 3 fixes we need (It doesn't have to be in a single patch).

Ihar, once Abhishek Raut send such a patch can you please review it and asses the risk/help him get it merged.

Kuba can you please review the patch as well when it is available.

Comment 7 Ihar Hrachyshka 2014-09-22 15:11:22 UTC
Setting NEEDINFO to the reporter. Once you backport the fixes in upstream, please provide the links to backports and clear NEEDINFO flag to inform us about backported patches being available for cherry-picking.

Comment 8 Abhishek Raut 2014-10-02 01:32:28 UTC
Review link for creation of quota tables as part of folsom_initial in stable/icehouse ->
https://review.openstack.org/#/c/124026/

Review link for quota support in n1kv monolithic plugin in stable/icehouse -> https://review.openstack.org/#/c/125531/

Comment 12 Ihar Hrachyshka 2014-10-20 07:55:10 UTC
As per Abhishek from Cisco, only one of the patches are included in the build, but they are ok with it. We'll backport the second auxiliary part later, but the quota tables should still be created by neutron server on startup.

Comment 16 errata-xmlrpc 2014-11-03 08:38:42 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2014-1786.html