Bug 1135499 (kf5-networkmanager-qt)
| Summary: | Review Request: kf5-networkmanager-qt - A Tier 1 KDE Frameworks 5 module that wraps NetworkManager DBus API | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Vrátil <dvratil> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | Jan Grulich <jgrulich> |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jeischma, jgrulich, kevin, package-review, rdieter |
| Target Milestone: | --- | Flags: | jgrulich:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-01-20 13:34:03 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1135495 | ||
| Bug Blocks: | 1135103 | ||
|
Description
Daniel Vrátil
2014-08-29 13:14:11 UTC
Missing to install COPYING.LIB and README.md. Except of that it looks good and can be fixed during import. I think we can skip a separate kf5- module, and re-use and upgrade the existing libnm-qt package/module already in fedora instead. That will give us a natural upgrade path, and nothing in f22/plasma5 should be relying on qt4 libnm-qt anyway. See my comment under kf5-libmm-qt review. libnm-qt is going to become a KDE Framework, so for the sake of consistency I'd prefer having kf5-libnm-qt, and eventually retire libnm-qt. Upstream has been renamed to networkmanager-qt, rename please the package accordingly. Spec URL: https://dvratil.fedorapeople.org/kf5/review/kf5-networkmanager-qt.spec SRPM URL: https://dvratil.fedorapeople.org/kf5/review/kf5-networkmanager-qt-5.6.0-1.fc21.src.rpm Renamed to kf5-networkmanager-qt, minor fixes. Already approved, just the url should be https://projects.kde.org/projects/frameworks/networkmanager-qt. New Package SCM Request ======================= Package Name: kf5-networkmanager-qt Short Description: KDE Frameworks 5 Tier 1 module that wraps NetworkManager DBus API Upstream URL: https://projects.kde.org/projects/frameworks/networkmanager-qt Owners: group::kde-sig Branches: f20 f21 InitialCC: Git done (by process-git-requests). |