Bug 1136297

Summary: ShellCheck-0.3.4 is available
Product: [Fedora] Fedora Reporter: Upstream Release Monitoring <upstream-release-monitoring>
Component: ShellCheckAssignee: Dridi Boukelmoune <dridi.boukelmoune>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: dridi.boukelmoune, haskell-devel, petersen
Target Milestone: ---Keywords: FutureFeature, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ShellCheck-0.3.4:ok
Fixed In Version: ShellCheck-0.3.4-1.fc21 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-10-01 03:44:40 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1138384    
Bug Blocks: 1052117    
Attachments:
Description Flags
spec file for hackage none

Description Upstream Release Monitoring 2014-09-02 09:54:26 UTC
Latest upstream release: 0.3.4
Current version/release in Fedora Rawhide: 0.3.3-0.fc22
URL: http://hackage.haskell.org/package/ShellCheck

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy


More information about the service that created this bug can be found at:
https://fedoraproject.org/wiki/Upstream_release_monitoring Soon this service will be implemented by a new system: https://github.com/fedora-infra/anitya/
It will require to manage monitored projects via a new web interface. Please make yourself familiar with the new system to ease the transition.

Comment 1 Jens Petersen 2014-09-04 05:34:39 UTC
fhbz: Rawhide can be updated to ShellCheck-0.3.4 
according to the current cblrepo data in haskell-sig.git
without any other package rebuilds.

Comment 2 Dridi Boukelmoune 2014-09-04 18:04:16 UTC
Almost there, there's only the QuickCheck issue left.

Comment 3 Jens Petersen 2014-09-05 06:22:12 UTC
You can workaround that with:

 %build
+LANG=en_US.utf8
 %ghc_lib_build

Comment 4 Jens Petersen 2014-09-05 06:27:14 UTC
Created attachment 934688 [details]
spec file for hackage

I think you don't need to use the github tarball anymore.
This spec builds fine for me and I don't see anything missing?

I recommend running "cblrpm diff" when updating and merging
in any new changes from ShellCheck.spec.cblrpm with a tool like
meld or emacs ediff.

Comment 5 Dridi Boukelmoune 2014-09-05 06:44:16 UTC
(In reply to Jens Petersen from comment #4)
> Created attachment 934688 [details]
> spec file for hackage
> 
> I think you don't need to use the github tarball anymore.
> This spec builds fine for me and I don't see anything missing?

I already have a spec for 0.3.4 using the hackage tarball and I hit the QuickCheck issue. I'll use your workaround and then diff my spec with yours to see whether I missed something (seems like you forgot to remove the rpath workaround).

This is why I've linked this to bug 1052117!

> I recommend running "cblrpm diff" when updating and merging
> in any new changes from ShellCheck.spec.cblrpm with a tool like
> meld or emacs ediff.

I usually use plain diff(1) and sometimes vimdiff, that should be fine too :)

Comment 6 Dridi Boukelmoune 2014-09-12 16:50:52 UTC
It works, except on ARM...
https://kojipkgs.fedoraproject.org//work/tasks/2307/7572307/build.log

I don't see anything interesting in the build log so I need to dig a bit.

Comment 7 Jens Petersen 2014-09-22 03:36:36 UTC
(In reply to Dridi Boukelmoune from comment #5)
> I already have a spec for 0.3.4 using the hackage tarball and I hit the
> QuickCheck issue. I'll use your workaround and then diff my spec with yours
> to see whether I missed something (seems like you forgot to remove the rpath
> workaround).

Thanks, yes sorry I realised after posting that you were already onto this. :-)

(In reply to Dridi Boukelmoune from comment #6)
> It works, except on ARM...
> https://kojipkgs.fedoraproject.org//work/tasks/2307/7572307/build.log

Sorry I missed this comment too (forgot to add myself to this bug).

Unfortunately TemplateHaskell is still not working well on ARM
which is the cause of this failure.  I worked around it now
by skipping the definition of the runTests on ARM (bug 1144919).

Comment 8 Fedora Update System 2014-10-26 22:19:51 UTC
ShellCheck-0.3.4-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/ShellCheck-0.3.4-1.fc21

Comment 9 Fedora Update System 2014-10-26 22:19:59 UTC
ShellCheck-0.3.4-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/ShellCheck-0.3.4-1.fc20

Comment 10 Fedora Update System 2014-10-26 22:20:04 UTC
ShellCheck-0.3.4-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/ShellCheck-0.3.4-1.fc19

Comment 11 Fedora Update System 2014-11-07 02:33:41 UTC
ShellCheck-0.3.4-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2014-11-07 02:37:53 UTC
ShellCheck-0.3.4-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2014-11-10 06:11:05 UTC
ShellCheck-0.3.4-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.