Bug 1136384

Summary:	Review Request: rubygem-rspec2-expectations - Rspec 2 expectations (should and matchers)
Product:	[Fedora] Fedora	Reporter:	Mamoru TASAKA <mtasaka>
Component:	Package Review	Assignee:	Josef Stribny <jstribny>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	hhorak, jstribny, package-review
Target Milestone:	---	Flags:	jstribny: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-11-12 02:15:38 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1136390

Description Mamoru TASAKA 2014-09-02 13:17:45 UTC

Spec URL: https://mtasaka.fedorapeople.org/Review_request/rspec2/rubygem-rspec2-expectations.spec
SRPM URL: https://mtasaka.fedorapeople.org/Review_request/rspec2/rubygem-rspec2-expectations-2.14.5-5.fc22.src.rpm
Description: 
rspec-expectations adds `should` and `should_not` to every object and includes
RSpec::Matchers, a library of standard matchers.

Fedora Account System Username: mtasaka

Comment 1 Mamoru TASAKA 2014-09-02 13:19:29 UTC

Note that to this package needs bootstap to enable test suite (see %need_bootstrap_set)

Comment 2 Josef Stribny 2014-09-08 08:59:25 UTC

I will take it for a review.

Comment 3 Josef Stribny 2014-09-08 10:21:47 UTC

1, Fix spelling:

"Rspec-2 expectations (should and matchers) " should be "RSpec 2 expectations (should and matchers)"

Comment 4 Mamoru TASAKA 2014-09-21 15:35:52 UTC

Thank you for comments

https://mtasaka.fedorapeople.org/Review_request/rspec2/rubygem-rspec2-expectations-2.14.5-6.fc.src.rpm
https://mtasaka.fedorapeople.org/Review_request/rspec2/rubygem-rspec2-expectations.spec

* Wed Sep 17 2014 Mamoru TASAKA <mtasaka> - 2.14.5-6
- Change summary a bit

Comment 5 Josef Stribny 2014-10-09 08:20:41 UTC

Thanks.

==> APPROVED.

Comment 6 Mamoru TASAKA 2014-11-04 06:35:32 UTC

Sorry for LOOOOONG delay. Thank you for review.

New Package SCM Request
=======================
Package Name: rubygem-rspec2-expectations
Short Description: Rspec 2 expectations (should and matchers)
Upstream URL: http://github.com/rspec/rspec-expectations
Owners: mtasaka
Branches: 
InitialCC:

Comment 7 Gwyn Ciesla 2014-11-05 12:01:35 UTC

Git done (by process-git-requests).

Comment 8 Mamoru TASAKA 2014-11-12 02:15:38 UTC

Imported, closing.

Thank you for review and git procedure.