Bug 1136389

Note that to this package needs bootstap to enable test suite (see %need_bootstrap_set)

I will take it for a review.

1, Fix spelling:

"Rspec-2 runner and formatters" should be probably "RSpec 2 runner and formatters"

2, Fix upstream URL to https://github.com/rspec/rspec-core

3, Why do you need two macros for bootstrapping? Isn't need_bootstrap enough?

4, Unnecessary requires and provides: it's auto-generated now.

Thank you for comments:

(In reply to Josef Stribny from comment #3)
> 4, Unnecessary requires and provides: it's auto-generated now.

- Requires: rubygem(rake) is not from gemspec Requires searcher
  (see comments in the spec file)
- Provides: rubygem(%{rpmgem_name}) = %{version}-%{release}
  (note: rpmgem_name is "rspec2", not "rspec") is not frpm
  gemspec Provides searcher (gem name is "rspec")

https://mtasaka.fedorapeople.org/Review_request/rspec2/rubygem-rspec2-core-2.14.8-3.fc.src.rpm
https://mtasaka.fedorapeople.org/Review_request/rspec2/rubygem-rspec2-core.spec

* Wed Sep 17 2014 Mamoru TASAKA <mtasaka> - 2.14.8-3
- Modify summary, URL
- Kill redundant macro

Mamoru, I talked with Vit briefly and we discussed the naming scheme for these RSpec 2 packages. Don't you think it would be better to name them as:

rubygem-rspec-core2
rubygem-rspec-expectation2
rubygem-rspec-mocks2

?

That would match the convention we use for all the other packages. Also, when looking for rubygem-rspec in package db, one would immediately see that the old 2.x version is around. What do you think? Could you change it? The naming scheme you have chosen implies more that core, expectation and mocks are sub-packages of rspec package.

(In reply to Josef Stribny from comment #5)
> Mamoru, I talked with Vit briefly and we discussed the naming scheme for
> these RSpec 2 packages. Don't you think it would be better to name them as:
> 
> rubygem-rspec-core2
> rubygem-rspec-expectation2
> rubygem-rspec-mocks2
> 
> ?

You already said here "the naming scheme for these >RSpec 2 packages<",
so it should mention "rspec2", not "core2" or "expectation2".
Some similar namings are "python2-foo" v.s. "python3-foo", not "python-foo2"
or "python-foo3".

> That would match the convention we use for all the other packages. 

No, it is opposite.

> Also,
> when looking for rubygem-rspec in package db, one would immediately see that
> the old 2.x version is around. What do you think? Could you change it? The
> naming scheme you have chosen implies more that core, expectation and mocks
> are sub-packages of rspec package.

Essentially so, because even currently when we do "yum install rubygem-rspec",
it pulls in -core, -expectations, -mocks. Similarly, when we do
"yum install rubygem-rspec2", it should pull in "-rspec2-core", "-mocks",
"-expectations", and it almost looks like these are subpackages of
rubygem-rspec2.

IMO if user do "yum install rubygem(rspec2)" and then pull in
rubygem-rspec-expection2 or so, it is more confusing.

Ok, the naming is imperfect in either case and there are other packages that follow this "convention" so I agree.

==> APPROVED.

Sorry for LOOOOONG delay. Thank you for review.

New Package SCM Request
=======================
Package Name: rubygem-rspec2-core
Short Description: Rspec-2 runner and formatters
Upstream URL: http://github.com/rspec/rspec-core
Owners: mtasaka
Branches: 
InitialCC:

Git done (by process-git-requests).

Imported, closing.

Thank you for review and git procedure.