Bug 1138122

Summary: forbid invalid address type for panic device
Product: Red Hat Enterprise Linux 6 Reporter: Jincheng Miao <jmiao>
Component: libvirtAssignee: Erik Skultety <eskultet>
Status: CLOSED WONTFIX QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: medium    
Version: 6.6CC: dyuan, eskultet, mzhan, rbalakri, zhwang
Target Milestone: rcKeywords: Upstream
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1138125 (view as bug list) Environment:
Last Closed: 2015-01-27 09:05:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1138125    

Description Jincheng Miao 2014-09-04 06:30:56 UTC
Description of problem:
panic device only could specify isa type address with iobase(ioport).
libvirt should forbid other address type for panic device in order to avoid confusion from users.


Version-Release number of selected component (if applicable):
libvirt-0.10.2-43.el6.x86_64
qemu-kvm-0.12.1.2-2.439.el6.x86_64


How reproducible:
100%

Steps to Reproduce:
1. add panic device to guest, which address is same with memballoon
# virsh edit r7
...
    <memballoon model='virtio'>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/>
    </memballoon>
    <panic>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/>
    </panic>
...

2. start it
# virsh start r7
Domain r7 started

# ps -ef | grep qemu
qemu     12136     1 13 02:26 ?        00:00:00 /usr/libexec/qemu-kvm -name r7 -S -M rhel6.6.0 -enable-kvm -m 1024 -realtime mlock=off -smp 1,sockets=1,cores=2,threads=1 -uuid 5a85c12d-6004-7c04-e2d2-55f723d977f4 -nodefconfig -nodefaults -chardev socket,id=charmonitor,path=/var/lib/libvirt/qemu/r7.monitor,server,nowait -mon chardev=charmonitor,id=monitor,mode=control -rtc base=utc -no-shutdown -device piix3-usb-uhci,id=usb,bus=pci.0,addr=0x1.0x2 -device virtio-serial-pci,id=virtio-serial0,bus=pci.0,addr=0x5 -drive file=/var/lib/libvirt/images/r7.qcow2,if=none,id=drive-virtio-disk0,format=qcow2,cache=none -device virtio-blk-pci,scsi=off,bus=pci.0,addr=0x6,drive=drive-virtio-disk0,id=virtio-disk0,bootindex=1 -netdev tap,fd=22,id=hostnet0,vhost=on,vhostfd=23 -device virtio-net-pci,netdev=hostnet0,id=net0,mac=52:54:00:07:f9:ca,bus=pci.0,addr=0x3 -chardev pty,id=charserial0 -device isa-serial,chardev=charserial0,id=serial0 -device usb-tablet,id=input0 -vnc 127.0.0.1:0 -vga qxl -global qxl-vga.ram_size=67108864 -global qxl-vga.vram_size=67108864 -device intel-hda,id=sound0,bus=pci.0,addr=0x4 -device hda-duplex,id=sound0-codec0,bus=sound0.0,cad=0 -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x7 -device pvpanic -msg timestamp=on

Expect result:
in step 1, report an error.

Comment 1 Erik Skultety 2014-09-10 11:29:12 UTC
Fixed upstream:

commit afb4c6b6634e16beb5ddbca3f1113c615e10e7e4
Author: Erik Skultety <eskultet>
Date:   Mon Sep 8 12:27:23 2014 +0200

    qemu: panic device: check for invalid address type
    
    qemu now checks for invalid address type for a panic device, which is
    currently implemented only to use ISA address type, thus rejecting
    any other options, except for leaving XML attributes blank, in that case,
    defaults are used (this behaviour remains the same from earlier verions).
    
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1138125
    
    Signed-off-by: Martin Kletzander <mkletzan>

v1.2.8-53-gafb4c6b