Bug 1138125
| Summary: | forbid invalid address type for panic device | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Jincheng Miao <jmiao> |
| Component: | libvirt | Assignee: | Erik Skultety <eskultet> |
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> |
| Severity: | low | Docs Contact: | |
| Priority: | medium | ||
| Version: | 7.1 | CC: | dyuan, libvirt-maint, mzhan, rbalakri, virt-bugs, zhwang |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | libvirt-1.2.13-1.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1138122 | Environment: | |
| Last Closed: | 2015-11-19 05:48:14 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1138122 | ||
| Bug Blocks: | |||
|
Description
Jincheng Miao
2014-09-04 06:34:37 UTC
Fixed upstream:
commit afb4c6b6634e16beb5ddbca3f1113c615e10e7e4
Author: Erik Skultety <eskultet>
Date: Mon Sep 8 12:27:23 2014 +0200
qemu: panic device: check for invalid address type
qemu now checks for invalid address type for a panic device, which is
currently implemented only to use ISA address type, thus rejecting
any other options, except for leaving XML attributes blank, in that case,
defaults are used (this behaviour remains the same from earlier verions).
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1138125
Signed-off-by: Martin Kletzander <mkletzan>
v1.2.8-53-gafb4c6b
I can reproduce this issue with libvirt-1.2.8-16.el7.x86_64.rpm, verify this bug with libvirt-1.2.15-2.el7.x86_64, the verify steps as following
steps
1. add panic device to guest, which address is same with memballoon,will fail to save the guest
# virsh edit 7.0
...
<memballoon model='virtio'>
<address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/>
</memballoon>
<panic>
<address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/>
</panic>
...
:wq
error: XML error: Attempted double use of PCI slot 0000:00:07.0 (may need "multifunction='on'" for device on function 0)
Failed. Try again? [y,n,i,f,?]:
2.Add panic device to guest which have different pci address with other device in guest's xml, start the guest, will get an expect error
#virsh dumpxml 7.0
--
<panic>
<address type='pci' domain='0x0000' bus='0x00' slot='0x09' function='0x0'/>
</panic>
# virsh start 7.0
error: Failed to start domain 7.0
error: unsupported configuration: panic is supported only with ISA address type
3.Add panic device to guest with virtio-serial address, start the guest, will get the expect error
#virsh dumpxml 7.0
--
<panic>
<address type='virtio-serial' controller='0' bus='0' port='3'/>
</panic>
# virsh start 7.0
error: Failed to start domain 7.0
error: unsupported configuration: panic is supported only with ISA address type
4.Start a guest with pure panic device, the guest could start successfully, also the panic function works well
#virsh dumpxml 7.0
--
<panic/>
# virsh start 7.0
Domain 7.0 started
#ps aux|grep qemu
--
-device pvpanic -msg timestamp=on
5.Start a guest with panic device with ISA address type, also panic function works well
#virsh dumpxml 7.0
--
<panic>
<address type='isa' iobase='0x505'/>
</panic>
# virsh start 7.0
Domain 7.0 started
According to the upper steps, mark this bug verified
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-2202.html |