Bug 1138292

Summary:	Review Request: perl-Dist-Zilla-Plugin-ReadmeFromPod - Automatically convert POD to a README for Dist::Zilla
Product:	[Fedora] Fedora	Reporter:	Petr Šabata <psabata>
Component:	Package Review	Assignee:	Petr Pisar <ppisar>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, ppisar
Target Milestone:	---	Flags:	ppisar: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc21	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-09-23 05:08:02 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Šabata 2014-09-04 12:40:29 UTC

Spec URL: https://psabata.fedorapeople.org/pkgs/perl-Dist-Zilla-Plugin-ReadmeFromPod/perl-Dist-Zilla-Plugin-ReadmeFromPod.spec
SRPM URL: https://psabata.fedorapeople.org/pkgs/perl-Dist-Zilla-Plugin-ReadmeFromPod/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc20.src.rpm
Description:
Generate the README file from main_module (or other if specified)
with Pod::Text.
Fedora Account System Username: psabata

Comment 1 Petr Pisar 2014-09-04 13:36:11 UTC

URL and Source0 are usable. Ok.
Source archive is original (SHA-256: 3b255ec052ef896e525217d0025fab0767b53ef7a940f89d683e870f51331f8a). Ok
License verified from README, LICENSE, and lib/Dist/Zilla/Plugin/ReadmeFromPod.pm. Ok.
Summary verified from lib/Dist/Zilla/Plugin/ReadmeFromPod.pm. Ok.
Description verified from lib/Dist/Zilla/Plugin/ReadmeFromPod.pm. Ok.
No XS code, noarch BuildArch is Ok.

FIX: Build-require `perl(IO::Handle)' (t/00-compile.t:22).

FIX: Do not build-require `perl(Dist::Zilla::File::InMemory)'. It's not used at tests.
FIX: Do not build-require `perl(Pod::Text)'. It's not used at tests.

All tests pass. Ok.

$ rpmlint perl-Dist-Zilla-Plugin-ReadmeFromPod.spec ../SRPMS/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc22.src.rpm ../RPMS/noarch/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc22.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc22.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Sep  4 15:20 /usr/share/doc/perl-Dist-Zilla-Plugin-ReadmeFromPod
-rw-r--r--    1 root    root                     2474 Nov  4  2013 /usr/share/doc/perl-Dist-Zilla-Plugin-ReadmeFromPod/Changes
-rw-r--r--    1 root    root                    18437 Nov  4  2013 /usr/share/doc/perl-Dist-Zilla-Plugin-ReadmeFromPod/LICENSE
-rw-r--r--    1 root    root                      721 Nov  4  2013 /usr/share/doc/perl-Dist-Zilla-Plugin-ReadmeFromPod/README
-rw-r--r--    1 root    root                     2180 Sep  4 15:20 /usr/share/man/man3/Dist::Zilla::Plugin::ReadmeFromPod.3pm.gz
drwxr-xr-x    2 root    root                        0 Sep  4 15:20 /usr/share/perl5/vendor_perl/Dist
drwxr-xr-x    2 root    root                        0 Sep  4 15:20 /usr/share/perl5/vendor_perl/Dist/Zilla
drwxr-xr-x    2 root    root                        0 Sep  4 15:20 /usr/share/perl5/vendor_perl/Dist/Zilla/Plugin
-rw-r--r--    1 root    root                     2069 Nov  4  2013 /usr/share/perl5/vendor_perl/Dist/Zilla/Plugin/ReadmeFromPod.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc22.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.18.2)
      1 perl(Dist::Zilla::Role::InstallTool) >= 5
      1 perl(Moose)
      1 perl(Moose::Autobox)
      1 perl(Pod::Text)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1

FIX: Require `perl(Pod::Simple) >= 3.23' (lib/Dist/Zilla/Plugin/ReadmeFromPod.pm:34). See <https://rt.cpan.org/Public/Bug/Display.html?id=90032> for the explanation.

$ rpm -q --provides -p ../RPMS/noarch/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc22.noarch.rpm | sort -f | uniq -c
      1 perl(Dist::Zilla::Plugin::ReadmeFromPod) = 0.21
      1 perl-Dist-Zilla-Plugin-ReadmeFromPod = 0.21-1.fc22
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc22.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7522721). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct all `FIX' items, and provide a new spec file.
Resolution: Package NOT approved.

Comment 2 Petr Šabata 2014-09-04 13:46:03 UTC

Thanks.  Package updated.

Comment 3 Petr Pisar 2014-09-04 14:13:06 UTC

Spec file changes:

$ diff -u perl-Dist-Zilla-Plugin-ReadmeFromPod.spec{.old,}--- perl-Dist-Zilla-Plugin-ReadmeFromPod.spec.old       2014-09-04 14:39:15.000000000 +0200
+++ perl-Dist-Zilla-Plugin-ReadmeFromPod.spec   2014-09-04 15:45:34.000000000 +0200
@@ -8,18 +8,18 @@
 Source0:        http://www.cpan.org/authors/id/F/FA/FAYLAND/Dist-Zilla-Plugin-ReadmeFromPod-%{version}.tar.gz
 BuildArch:      noarch
 BuildRequires:  perl
-BuildRequires:  perl(Dist::Zilla::File::InMemory)
 BuildRequires:  perl(Dist::Zilla::Role::InstallTool) >= 5
 BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.76
 BuildRequires:  perl(File::Spec)
+BuildRequires:  perl(IO::Handle)
 BuildRequires:  perl(IPC::Open3)
 BuildRequires:  perl(Moose)
 BuildRequires:  perl(Moose::Autobox)
-BuildRequires:  perl(Pod::Text)
 BuildRequires:  perl(strict)
 BuildRequires:  perl(Test::More)
 BuildRequires:  perl(warnings)
 Requires:       perl(Dist::Zilla::Role::InstallTool) >= 5
+Requires:       perl(Pod::Simple) >= 3.23
 Requires:       perl(Pod::Text)
 Requires:       perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo $version))


> FIX: Build-require `perl(IO::Handle)' (t/00-compile.t:22).
+BuildRequires:  perl(IO::Handle)
Ok.

> FIX: Do not build-require `perl(Dist::Zilla::File::InMemory)'. It's not used
> at tests.
-BuildRequires:  perl(Dist::Zilla::File::InMemory)
Ok.

> FIX: Do not build-require `perl(Pod::Text)'. It's not used at tests.
-BuildRequires:  perl(Pod::Text)
Ok.

$ rpmlint perl-Dist-Zilla-Plugin-ReadmeFromPod.spec ../SRPMS/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc22.src.rpm ../RPMS/noarch/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc22.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

> FIX: Require `perl(Pod::Simple) >= 3.23' (lib/Dist/Zilla/Plugin/ReadmeFromPod.pm:34). See <https://rt.cpan.org/Public/Bug/Display.html?id=90032> for the explanation.
$ rpm -q --requires -p ../RPMS/noarch/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc22.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.18.2)
      1 perl(Dist::Zilla::Role::InstallTool) >= 5
      1 perl(Moose)
      1 perl(Moose::Autobox)
      1 perl(Pod::Simple) >= 3.23
      1 perl(Pod::Text)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Binary requires are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc22.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7523178). Ok.

Resolution: Package APPROVED.

Comment 4 Petr Šabata 2014-09-04 14:25:21 UTC

New Package SCM Request
=======================
Package Name: perl-Dist-Zilla-Plugin-ReadmeFromPod
Short Description: Automatically convert POD to a README for Dist::Zilla
Upstream URL: http://search.cpan.org/dist/Dist-Zilla-Plugin-ReadmeFromPod/
Owners: psabata jplesnik ppisar
Branches: f21
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2014-09-04 15:15:20 UTC

Git done (by process-git-requests).

Comment 6 Petr Šabata 2014-09-04 16:12:23 UTC

Thank you.

Comment 7 Fedora Update System 2014-09-04 16:18:32 UTC

perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc21

Comment 8 Fedora Update System 2014-09-06 01:00:50 UTC

perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc21 has been pushed to the Fedora 21 testing repository.

Comment 9 Fedora Update System 2014-09-23 05:08:02 UTC

perl-Dist-Zilla-Plugin-ReadmeFromPod-0.21-1.fc21 has been pushed to the Fedora 21 stable repository.