Bug 1138455
| Summary: | Review Request: rubygem-occi-core - OCCI toolkit | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | František Dvořák <valtri> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bloch, package-review |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-occi-core-4.3.2-1.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-12-13 09:39:04 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1141569, 1149407 | ||
|
Description
František Dvořák
2014-09-04 20:27:55 UTC
Spec URL: http://scientific.zcu.cz/fedora/rubygem-occi-core-4.2.17-1/rubygem-occi-core.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-occi-core-4.2.17-1/rubygem-occi-core-4.2.17-1.fc22.src.rpm koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7942110 * Sat Oct 25 2014 František Dvořák <valtri.cz> - 4.2.17-1 - Update to 4.2.17 Taking. I would appreciate it if you would swap reviews with my bug 1164566 . Mostly okay, some suggestions or so
* Latest version
- is 4.3.2, please update (diff seems not so long)
* %license
- For license file, using %license is now recommended.
* Usually non-needed files
- Files only used for test suite need not be packaged (spec/).
We usually don't package this on autotools based packages,
and it is explained also on:
https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites
- Gemfile, Rakefile are alike "Makefile" in autotools based
packages and we usually don't need this on runtime.
(In reply to Mamoru TASAKA from comment #3) > * Latest version > - is 4.3.2, please update (diff seems not so long) > OK. I used the older branch, where the dependent package rOCCI-server has fewer dependencies. But it's true it should be used the newest version, and there can be disabled some backends on the rOCCI-server, if needed. :-) > * %license > - For license file, using %license is now recommended. > Done. > * Usually non-needed files > - Files only used for test suite need not be packaged (spec/). > We usually don't package this on autotools based packages, > and it is explained also on: > > https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/ > Ruby#Running_test_suites > Done. I see, there is obvious "don't include tests" message. :-) > - Gemfile, Rakefile are alike "Makefile" in autotools based > packages and we usually don't need this on runtime. OK, removed. Thanks for the review! New version: Spec URL: http://scientific.zcu.cz/fedora/rubygem-occi-core-4.3.2-1/rubygem-occi-core.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-occi-core-4.3.2-1/rubygem-occi-core-4.3.2-1.fc22.src.rpm * Thu Nov 27 2014 František Dvořák <valtri.cz> - 4.3.2-1 - Update to 4.3.2 - Removed rails >= 4.1 compatibility patch - The license file marked by %%license macro - Removed tests and build files Approving. ---------------------------------------------------------------- This package (rubygem-occi-core) is APPROVED by mtasaka ---------------------------------------------------------------- New Package SCM Request ======================= Package Name: rubygem-occi-core Short Description: OCCI toolkit Upstream URL: https://github.com/EGI-FCTF/rOCCI-core Owners: valtri Branches: f20 f21 InitialCC: Git done (by process-git-requests). rubygem-occi-core-4.3.2-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/rubygem-occi-core-4.3.2-1.fc21 rubygem-occi-core-4.3.2-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/rubygem-occi-core-4.3.2-1.fc20 rubygem-occi-core-4.3.2-1.fc21 has been pushed to the Fedora 21 testing repository. rubygem-occi-core-4.3.2-1.fc20 has been pushed to the Fedora 20 stable repository. rubygem-occi-core-4.3.2-1.fc21 has been pushed to the Fedora 21 stable repository. |