Bug 1139195

Summary:	vdsm invoked oom-killer during rebalance and Killed process 4305, UID 0, (glusterfs nfs process)
Product:	[Community] GlusterFS	Reporter:	santosh pradhan <spradhan>
Component:	nfs	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	mainline	CC:	arawat, bhubbard, bugs, cww, gluster-bugs, ndevos, rtalur, vagarwal
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1125658	Environment:
Last Closed:	2015-05-15 17:08:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1125658, 1139244, 1139245, 1139250, 1147460

Comment 1 Anand Avati 2014-09-08 11:20:35 UTC

REVIEW: http://review.gluster.org/8651 (gNFS: Fix memory leak in setacl code path) posted (#1) for review on master by Santosh Pradhan (spradhan)

Comment 2 Anand Avati 2014-09-08 13:01:33 UTC

COMMIT: http://review.gluster.org/8651 committed in master by Niels de Vos (ndevos) 
------
commit 5c869aea79c0f304150eac014c7177e74ce0852e
Author: Santosh Kumar Pradhan <spradhan>
Date:   Mon Sep 8 16:44:23 2014 +0530

    gNFS: Fix memory leak in setacl code path
    
    If ACL is set on a file in Gluster NFS mount (setfacl command),
    and it succeed, then the NFS call state data is leaked. Though
    all the failure code path frees up the memory.
    
    Impact: There is a OOM kill i.e. vdsm invoked oom-killer during
    rebalance and Killed process 4305, UID 0, (glusterfs nfs process)
    
    FIX:
    Make sure to deallocate the memory for call state in acl3_setacl_cbk()
    using nfs3_call_state_wipe();
    
    Signed-off-by: Santosh Kumar Pradhan <spradhan>
    
    Change-Id: I9caa3f851e49daaba15be3eec626f1f2dd8e45b3
    BUG: 1139195
    Signed-off-by: Santosh Kumar Pradhan <spradhan>
    Reviewed-on: http://review.gluster.org/8651
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 3 Anand Avati 2014-09-09 06:46:58 UTC

REVIEW: http://review.gluster.org/8661 (gNFS: Fix memory leak in setacl code path) posted (#1) for review on release-3.5 by Santosh Pradhan (spradhan)

Comment 6 Niels de Vos 2015-05-15 17:08:56 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user