Bug 1139250

Summary:	vdsm invoked oom-killer during rebalance and Killed process 4305, UID 0, (glusterfs nfs process)
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	nfs	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	3.4.5	CC:	bugs, gluster-bugs, kkeithle
Target Milestone:	---	Keywords:	Patch
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-04-13 07:05:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1139195
Bug Blocks:	1125245

Description Niels de Vos 2014-09-08 13:16:38 UTC

3.4 needs the following backport:


COMMIT: http://review.gluster.org/8651 committed in master by Niels de Vos (ndevos) 
------
commit 5c869aea79c0f304150eac014c7177e74ce0852e
Author: Santosh Kumar Pradhan <spradhan>
Date:   Mon Sep 8 16:44:23 2014 +0530

    gNFS: Fix memory leak in setacl code path
    
    If ACL is set on a file in Gluster NFS mount (setfacl command),
    and it succeed, then the NFS call state data is leaked. Though
    all the failure code path frees up the memory.
    
    Impact: There is a OOM kill i.e. vdsm invoked oom-killer during
    rebalance and Killed process 4305, UID 0, (glusterfs nfs process)
    
    FIX:
    Make sure to deallocate the memory for call state in acl3_setacl_cbk()
    using nfs3_call_state_wipe();
    
    Signed-off-by: Santosh Kumar Pradhan <spradhan>
    
    Change-Id: I9caa3f851e49daaba15be3eec626f1f2dd8e45b3
    BUG: 1139195
    Signed-off-by: Santosh Kumar Pradhan <spradhan>
    Reviewed-on: http://review.gluster.org/8651
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 1 Anand Avati 2014-09-08 14:19:11 UTC

REVIEW: http://review.gluster.org/8653 (gNFS: Fix memory leak in setacl code path) posted (#1) for review on release-3.4 by Kaleb KEITHLEY (kkeithle)

Comment 2 Anand Avati 2014-09-09 11:16:14 UTC

COMMIT: http://review.gluster.org/8653 committed in release-3.4 by Kaleb KEITHLEY (kkeithle) 
------
commit c0b40b5bb1ff73131c743d74d3da16a28b2cbd28
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Mon Sep 8 10:16:58 2014 -0400

    gNFS: Fix memory leak in setacl code path
    
    Backport of http://review.gluster.org/#/c/8651 (BZ # 1139195) to
    release-3.4
    
    If ACL is set on a file in Gluster NFS mount (setfacl command),
    and it succeed, then the NFS call state data is leaked. Though
    all the failure code path frees up the memory.
    
    Impact: There is a OOM kill i.e. vdsm invoked oom-killer during
    rebalance and Killed process 4305, UID 0, (glusterfs nfs process)
    
    FIX:
    Make sure to deallocate the memory for call state in acl3_setacl_cbk()
    using nfs3_call_state_wipe();
    
    Change-Id: I6664a9151e9417e114c858bb2cdb136d9cb0b283
    BUG: 1139250
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/8653
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Santosh Pradhan <spradhan>
    Reviewed-by: Niels de Vos <ndevos>