Bug 1140324 (pjproject)
Summary: | Review Request: pjproject - Libraries for building VoIP applications | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jared Smith <jsmith.fedora> |
Component: | Package Review | Assignee: | Peter Robinson <pbrobinson> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | amessina, bugzilla-redhat, fedora, g.devel, kevin, lmadsen, package-review, pahan, projects.rg |
Target Milestone: | --- | Flags: | pbrobinson:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | pjproject-2.3-6.el7 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-09-20 16:44:27 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 692131, 1130101 |
Description
Jared Smith
2014-09-10 16:59:10 UTC
*** Bug 728302 has been marked as a duplicate of this bug. *** Just to save some time/effort, here's the output of rpmlint on the spec file, source RPM, and produced binary RPMs: [jsmith@slapshot pjproject]$ rpmlint pjproject.spec pjproject-2.3-2.fc21.src.rpm pjproject-2.3-2.fc21.x86_64.rpm pjproject-devel-2.3-2.fc21.x86_64.rpm pjproject-devel.x86_64: W: only-non-binary-in-usr-lib pjproject-devel.x86_64: W: no-documentation 3 packages and 1 specfiles checked; 0 errors, 2 warnings. > rm -rf third_party/mp3
If this contains an MP3 encoder and/or decoder, this directory needs to be completely removed from the tarball, not just removed in %prep. The same goes for any other patent-encumbered codecs. (If in doubt, rip out ALL the bundled libraries from the tarball, you have to ship a cleaned tarball anyway, so you may as well delete everything unwanted.)
(The reason: Code with patent issues cannot be shipped even in the SRPM.) It does not contain either an MP3 encoder or decoder -- it's simply a stub to be able to use an external MP3 encoder/decoder if the DLL is found on Windows. I think we're perfectly fine here. Yes, that's fine to delete in %prep (as you're already doing) then. Is there a package that will depend on pjproject? Otherwise what example / application could be used to test the library? (In reply to Raphael Groner from comment #7) > Is there a package that will depend on pjproject? Otherwise what example / > application could be used to test the library? Asterisk 13 Looks fine. APPROVED A few minor bits you might consider: - document in the spec file the reason the audio/video is disabled in the spec for easy reference - Use the new %license directive + rpmlint output rpmlint pjproject-2.3-2.fc21.src.rpm pjproject-2.3-2.fc21.x86_64.rpm pjproject-devel-2.3-2.fc21.x86_64.rpm pjproject-debuginfo-2.3-2.fc21.x86_64.rpm pjproject.spec pjproject-devel.x86_64: W: only-non-binary-in-usr-lib pjproject-devel.x86_64: W: no-documentation 4 packages and 1 specfiles checked; 0 errors, 2 warnings. + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license + latest version packaged + %doc includes license file * Might be useful to use the new %license tag + spec file written in American English + spec file is legible + upstream sources match sources in the srpm 8440e43242c439ae5ec30b5b85005fce pjproject-2.3.tar.bz2 + package successfully builds on at least one architecture tested using koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=7572191 + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* + binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr + package owns all directories it creates + no duplicate files in %files + Package perserves timestamps on install + Permissions on files must be set properly + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package runtime + header files should be in -devel n/a static libraries should be in -static + libfoo.so must go in -devel + devel must require the fully versioned base + packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + filenames must be valid UTF-8 Optional: n/a if there is no license file, packager should query upstream to include it n/a translations of description and summary for non-English languages, if available + reviewer should build the package in mock/koji + the package should build into binary RPMs on all supported architectures n/a review should test the package functions as described + scriptlets should be sane n/a non -devel packages should require fully versioned base + pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin n/a Package should have man files New Package SCM Request ======================= Package Name: pjproject Short Description: Communications library for SIP, SDP, RTP, STUN, TURN, and ICE Upstream URL: http://pjsip.com/ Owners: jsmith Branches: f19 f20 f21 el6 epel7 InitialCC: Git done (by process-git-requests). pjproject-2.3-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/pjproject-2.3-2.fc21 pjproject-2.3-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/pjproject-2.3-2.fc20 pjproject-2.3-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/pjproject-2.3-2.fc19 pjproject-2.3-2.fc20 has been pushed to the Fedora 20 stable repository. pjproject-2.3-2.fc21 has been pushed to the Fedora 21 stable repository. pjproject-2.3-2.fc19 has been pushed to the Fedora 19 stable repository. pjproject-2.3-6.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/pjproject-2.3-6.el7 pjproject-2.3-6.el7 has been pushed to the Fedora EPEL 7 stable repository. |