Bug 1140599

Summary:	[engine-setup] setup fails if the user decide to configure websocket proxy without having installed websocketproxy rpm
Product:	[Retired] oVirt	Reporter:	Simone Tiraboschi <stirabos>
Component:	ovirt-engine-installer	Assignee:	Simone Tiraboschi <stirabos>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Jiri Belka <jbelka>
Severity:	high	Docs Contact:
Priority:	low
Version:	3.5	CC:	benl, bsanford, bugs, didi, ecohen, gklein, iheim, lsurette, pmatyas, pvine, rbalakri, sbonazzo, tpelka, vipatel, yeylon, ylavi
Target Milestone:	---
Target Release:	3.5.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	integration
Fixed In Version:	ovirt-3.5.1_rc1	Doc Type:	Bug Fix
Doc Text:	Cause: setup fails if the user decide to configure websocket proxy without having installed websocketproxy rpm Consequence: setup fails Fix: Making setup able to download websocket proxy rpm Result: If the user decide to configure the websocket proxy and its rpm is not installed, engine-setup downloads and installs it	Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-04-29 06:19:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1098191, 1193058, 1196662, 1197441

Description Simone Tiraboschi 2014-09-11 10:22:22 UTC

Description of problem:
ovirt-engine-websocket-proxy depends from ovirt-engine-setup-plugin-websocket-proxy but ovirt-engine-setup-plugin-websocket-proxy doesn't depends from ovirt-engine-websocket-proxy so the user can run engine-setup having ovirt-engine-setup-plugin-websocket-proxy rpm but without having ovirt-engine-websocket-proxy rpm.
In that case setup will fail trying to start websocket-proxy simply because it's not available on the system.


Version-Release number of selected component (if applicable):
3.5.0

How reproducible:
100%

Steps to Reproduce:
1. yum install ovirt-engine-websocket-proxy
2. yum remove ovirt-engine-websocket-proxy
2. yum install ovirt-engine-setup-plugin-websocket-proxy
3. engine-setup

Actual results:
engine-setup fails

Expected results:
engine-setup installs ovirt-engine-websocket-proxy rpm and completes sucessfully

Additional info:

Comment 1 Bill Sanford 2014-10-21 14:30:47 UTC

The default in the "rhevm-setup" is to look for the "ovirt-engine-websocket-proxy" and not the "rhevm-websocket-proxy" which is installed as "rhevm-websocket-proxy-3.5.0-0.15.beta.el6ev.noarch"

[root@rhevm35 ~]# rhevm-setup
[ INFO  ] Stage: Initializing
[ INFO  ] Stage: Environment setup
          Configuration files: ['/etc/ovirt-engine-setup.conf.d/10-packaging.conf']
          Log file: /var/log/ovirt-engine/setup/ovirt-engine-setup-20141021102843-566nw9.log
          Version: otopi-1.3.0 (otopi-1.3.0-1.el6ev)
[ INFO  ] Stage: Environment packages setup
[ INFO  ] Stage: Programs detection
[ INFO  ] Stage: Environment setup
[ INFO  ] Stage: Environment customization
         
          --== PRODUCT OPTIONS ==--
         
          Configure Engine on this host (Yes, No) [Yes]: 
          Configure WebSocket Proxy on this host (Yes, No) [Yes]: 
         
          --== PACKAGES ==--
         

[ INFO  ] Checking for product updates...
[ ERROR ] Yum: Cannot queue package ovirt-engine-websocket-proxy: Package ovirt-engine-websocket-proxy cannot be found
[ INFO  ] Yum: Performing yum transaction rollback
[ ERROR ] Failed to execute stage 'Environment customization': Package ovirt-engine-websocket-proxy cannot be found
[ INFO  ] Stage: Clean up
          Log file is located at /var/log/ovirt-engine/setup/ovirt-engine-setup-20141021102843-566nw9.log
[ INFO  ] Generating answer file '/var/lib/ovirt-engine/setup/answers/20141021102907-setup.conf'
[ INFO  ] Stage: Pre-termination
[ INFO  ] Stage: Termination
[ ERROR ] Execution of setup failed
[root@rhevm35 ~]# 

[root@rhevm35 ~]# yum install ovirt-engine-websocket-proxy
Loaded plugins: product-id, refresh-packagekit, rhnplugin, security, subscription-manager, versionlock
This system is receiving updates from RHN Classic or RHN Satellite.
Setting up Install Process
No package ovirt-engine-websocket-proxy available.
Error: Nothing to do
[root@rhevm35 ~]#

Comment 2 Simone Tiraboschi 2014-10-21 15:29:03 UTC

(In reply to Bill Sanford from comment #1)
> The default in the "rhevm-setup" is to look for the
> "ovirt-engine-websocket-proxy" and not the "rhevm-websocket-proxy" which is
> installed as "rhevm-websocket-proxy-3.5.0-0.15.beta.el6ev.noarch"

Thanks Bill, we already noticed that, please check
https://gerrit.eng.lab.tlv.redhat.com/14465

It should be included in vt7.

Comment 3 Yedidyah Bar David 2014-10-22 12:15:21 UTC

Current builds of rhevm fail due to the fix for this bug. A workaround until the next build:

engine-setup --otopi-environment='OVESETUP_WSP_RPMDISRO_PACKAGES=str:rhevm-websocket-proxy OVESETUP_WSP_RPMDISRO_PACKAGES_SETUP=str:rhevm-setup-plugin-websocket-proxy'

Comment 4 Sandro Bonazzola 2015-01-15 14:15:40 UTC

This is an automated message: 
This bug should be fixed in oVirt 3.5.1 RC1, moving to QA

Comment 5 Sandro Bonazzola 2015-01-21 16:06:39 UTC

oVirt 3.5.1 has been released. If problems still persist, please make note of it in this bug report.

Comment 6 Eyal Edri 2015-02-26 12:33:16 UTC

this ovirt bug was fixed during 3.5.1 cycle and is included in the build, and therefore should be verified.

Comment 7 Yaniv Lavi 2015-03-02 08:09:28 UTC

This is moved to oVirt 3.5.2 to test only. This issue is already patched in 3.5.1.

Comment 8 Jiri Belka 2015-03-16 14:41:19 UTC

ok rhevm-setup-plugin-websocket-proxy-3.5.1-0.1.el6ev.noarch

Comment 9 Eyal Edri 2015-04-29 06:19:46 UTC

ovirt 3.5.2 was GA'd. closing current release.