Bug 1140812

Description of problem:
DKMS inter-module dependencies feature is broken and does not handle simple scenarios like spl->zfs->lustre required build order discovery when both zfs and lustre DKMS RPMs have correctly provided a dkms.conf config-file with respectively BUILD_DEPENDS[0]="spl" and BUILD_DEPENDS[0]="zfs" statements.

Version-Release number of selected component (if applicable):
2.2.0.3-20.fc20

How reproducible:
on demand

Steps to Reproduce:
1. install lustre-dkms, spl-dkms, zfs-dkms RPMs along with a new kernel RPM and its kernel-devel companion.
2. reboot. lustre modules rebuild will fail (missing zfs sources/headers), when zfs and spl will succesfully.
3. a 2nd reboot should fix/work now zfs has builded.

you can also force it to reproduce without any reboot with the following steps :
1. dkms remove [lustre,zfs,spl] modules
2. dkms add [lustre,zfs,spl] modules
3. dkms autoinstall, will fail like during a reboot. And a second autoinstall should fix/work.

Actual results:
Automated DKMS rebuild fails. Need manual/human intervention to fix!

Expected results:
Automated DKMS rebuild success.

Additional info:

The problem is that upon 1st reboot/autoinstall, DKMS seems to correctly detect that all 3 modules need to be rebuilt, but then lustre-dkms is rebuilt without regards to its zfs dependency and fails, when in the same time spl-dkms is correctly rebuilt before zfs-dkms to satisfy their own inter-dependency. Upon 2nd reboot/autoinstall, lustre-dkms rebuild is again attempted and can succeed.

Having a look to the dkms source-code/script, I think this problem comes from the fact that the inter-modules dependencies detection code is buggy and that the following patch will fix it :
=============================================================================
--- ./dkms.orig 2014-09-10 08:05:43.000000000 -0700
+++ ./dkms.bfi  2014-09-11 11:15:01.000000000 -0700
@@ -3181,9 +3181,20 @@
 
     # Walk through our list of installed and built modules, and create
     # a list of modules that need to be reinstalled.
+    # Assuming all versions of same module to be parsed sequentially.
     while read status mvka; do
         IFS='/' read m v k a <<< "$mvka"
         [[ ! $last_m ]] && last_m="$m"
+        # autoinstall previous module's latest version after its deps.
+        if [[ $last_m != $m ]]; then
+            if [[ $tenative ]]; then
+                to_install[${#to_install[@]}]="$tenative"
+                build_depends["$last_m"]="${BUILD_DEPENDS[@]}"
+            fi
+            last_m="$m"
+            last_v='0'
+            tenative=''
+       fi
         # If the module is already installed or weak-installed, skip it.
         if _is_module_installed "$m" "$v" "$kernelver" "$arch"; then
                installed_modules[${#installed_modules[@]}]="$m"
@@ -3197,27 +3208,21 @@
         read_conf_or_die "$k" "$a" "$dkms_tree/$m/$v/source/dkms.conf"
         if [[ ! $AUTOINSTALL ]]; then
             continue
-        # otherwise, only autoinstall the latest version we have hanging around.
-        elif [[ $last_m != $m ]]; then
-            last_m="$m"
-            last_v='0'
-            if [[ $tenative ]]; then
-                to_install[${#to_install[@]}]="$tenative"
-                build_depends["$m"]="${BUILD_DEPENDS[@]}"
-            fi
-            tenative=''
         fi
+       # otherwise, only autoinstall the latest version we have hanging around.
         if [[ ($(VER $v) > $(VER $last_v)) ]]; then
             last_v="$v"
             tenative="$m/$v"
         fi
     done < <(module_status)
+
     # We may have exited the loop with $tenative set.  If it is,
     # it contains something that should be updated.
     if [[ $tenative ]]; then
         to_install[${#to_install[@]}]="$tenative"
         build_depends["$m"]="${BUILD_DEPENDS[@]}"
     fi
+
     [[ $to_install ]] || return 0
 
        while true; do
@@ -3257,6 +3262,11 @@
                # Step 4: Remove modules that were installed during Step 2 from
                # the job queue.
                to_install=( "${next_install[@]}" )
+
+       done
+       for mv in "${to_install[@]}"; do
+               IFS=/ read m v <<< "$mv"
+               echo "$m/$v autoinstall failed due to missing dependencies: ${build_depends[$m]}"
        done
 } 

=============================================================================
At least it fixes the spl->zfs->lustre scenario!
It will also report module re-build failures due to missing dependencies.

BTW, what is the current git repo for DKMS and where I can submit this patch proposal ??