Bug 1140912

Summary: exception when submitting job with invalid user: AttributeError: 'NoneType' object has no attribute 'user_id'
Product: [Retired] Beaker Reporter: Dan Callaghan <dcallagh>
Component: generalAssignee: Dan Callaghan <dcallagh>
Status: CLOSED CURRENTRELEASE QA Contact: tools-bugs <tools-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 0.18CC: aigao, asaha, dcallagh, dowang
Target Milestone: 19.1Keywords: EasyFix, Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-12-17 08:40:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dan Callaghan 2014-09-12 03:05:38 UTC
Version-Release number of selected component (if applicable):
0.18

Steps to Reproduce:
1. Submit job with nonsense in the user="" attribute of the <job/> element, for example:
<job user="${GERRIT_EVENT_ACCOUNT_NAME}"...

Actual results:
bkr.server.xmlrpccontroller ERROR Error handling XML-RPC method
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/bkr/server/xmlrpccontroller.py", line 53, in RPC2
    response = self.process_rpc(method,params)
  File "/usr/lib/python2.6/site-packages/bkr/server/xmlrpccontroller.py", line 42, in process_rpc
    response = obj(*params)
  File "<string>", line 2, in upload
  File "/usr/lib/python2.6/site-packages/bkr/server/identity.py", line 247, in require
    return func(*args, **kwargs)
  File "/usr/lib/python2.6/site-packages/bkr/server/jobs.py", line 339, in upload
    ignore_missing_tasks=ignore_missing_tasks)
  File "/usr/lib/python2.6/site-packages/bkr/server/jobs.py", line 489, in process_xmljob
    if not submitter.is_delegate_for(owner):
  File "/usr/lib/python2.6/site-packages/bkr/server/model/identity.py", line 142, in is_delegate_for
    user_id=user.user_id).first() is not None
AttributeError: 'NoneType' object has no attribute 'user_id'

Expected results:
More useful error.

Comment 1 Dan Callaghan 2014-11-24 00:44:16 UTC
http://gerrit.beaker-project.org/3502

Comment 4 Dan Callaghan 2014-12-17 08:40:20 UTC
Beaker 19.1 is released.