Bug 1141093

Summary: rhc snapshot save different app with the same name in the same dir didn't prompt conflict information
Product: OpenShift Online Reporter: Qixuan Wang <qixuan.wang>
Component: ocAssignee: Vu Dinh <vdinh>
Status: CLOSED WONTFIX QA Contact: libra bugs <libra-bugs>
Severity: low Docs Contact:
Priority: medium    
Version: 2.xCC: bleanhar, jialiu, jokerman, libra-bugs, libra-onpremise-devel, lmeyer, mmasters, mmccomas, vdinh, xtian
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1139608
: 1308716 (view as bug list) Environment:
Last Closed: 2017-05-31 18:22:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1139608, 1308716    

Description Qixuan Wang 2014-09-12 08:09:19 UTC 
+++ This bug was initially created as a clone of Bug #1139608 +++

Description of problem:
 
rhc snapshot save a app with the name a.tar.gz in /root/desktop dir, snapshot save another app with the same name a.tar.gz in /root/desktop dir, system didn't prompt conflict information

Version-Release number of selected component (if applicable):
rhc 1.29.3.1

How reproducible:
always

Steps to Reproduce:
1.rhc snapshot save app -f 'a.tar.gz'
2.rhc snapshot save app2 -f 'a.tar.gz'

Actual results:
after step 1~2, prompt conflict information

Expected results:
after step 1~2, didn't prompt conflict information , cover the first file.

Additional info:


Tested on STG(devenv-stage_1006), same issue in OpenShift Online
Comment 1 Vu Dinh 2015-11-25 19:53:08 UTC 
The description for this bug doesn't match the Actual/Expected results section. I believe they are switched. It should be like this instead:

Actual results:
after step 1~2, didn't prompt conflict information , cover the first file.

Expected results:
after step 1~2, prompt conflict information

Thanks,
Vu
Comment 2 openshift-github-bot 2015-12-03 15:46:53 UTC 
Commit pushed to master at https://github.com/openshift/rhc

https://github.com/openshift/rhc/commit/f982979f0c198dbb5992439ffb340a9deacaae7b
Bug 1141093 - rhc snapshot save same filename didn't prompt conflict warning

The 'rhc snapshot save -f' command overwrites existing file without warning
if user inputs same filename for two different apps.

This commit modifies the rhc snapshow command to verify if the file already
exists and ask user for confirmation before proceeding.

Bug 1141093
Link <https://bugzilla.redhat.com/show_bug.cgi?id=1141093>

Signed-off-by: Vu Dinh <vdinh>
Comment 3 Qixuan Wang 2015-12-04 09:16:41 UTC 
Tested on devenv_5729, rhc-1.38.4, I agree with your comment 1, that sounds more reasonable. The bug has been fixed, thanks.

Here is the result:

[root@qwang test]# rhc snapshot save py26 -f 'app.tar.gz'
Pulling down a snapshot of application 'py26' to app.tar.gz ... done

[root@qwang test]# rhc snapshot save php54 -f 'app.tar.gz'
File app.tar.gz already exists. Do you want to overwrite this file? (yes|no): yes
Pulling down a snapshot of application 'php54' to app.tar.gz ... done
Comment 4 Eric Paris 2017-05-31 18:22:11 UTC 
We apologize, however, we do not plan to address this report at this time. The majority of our active development is for the v3 version of OpenShift. If you would like for Red Hat to reconsider this decision, please reach out to your support representative. We are very sorry for any inconvenience this may cause.