Bug 1141390
| Summary: | Review Request: perl-DBIx-RunSQL - Run SQL commands from a file | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Denis Fateyev <denis> |
| Component: | Package Review | Assignee: | David Dick <ddick> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ddick, package-review, perl-devel |
| Target Milestone: | --- | Flags: | ddick:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-DBIx-RunSQL-0.12-2.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-10-20 09:55:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Denis Fateyev
2014-09-13 00:34:42 UTC
Builds successfully at http://koji.fedoraproject.org/koji/taskinfo?taskID=7739321 Licensing is correct rpmlint contains a warning for DOS line endings in README which can be fixed by including the following BRs. Add the following BRs BR: perl(Pod::Readme) BR: perl(Pod::Markdown) As before, i think that "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;" can be removed even for EPEL5 builds. I skipped Pod::Readme and Pod::Markdown dependencies intentionally because they didn't affect the build or core functionality, - and the first was missing in epel7 [1], the second was missing both in el5 and el6 [2]. $ rpmlint perl-DBIx-RunSQL-0.12-1.fc22.src.rpm perl-DBIx-RunSQL-0.12-1.fc22.noarch.rpm perl-DBIx-RunSQL.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-DBIx-RunSQL/README 2 packages and 0 specfiles checked; 0 errors, 1 warnings. I think they can be omitted but if it's important I can either add a conditional for el5,el6 or exclude them from build entirely (actually, I wouldn't do that.) [1] http://pkgs.fedoraproject.org/cgit/perl-Pod-Readme.git I've recently posted the update: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2014-2808/perl-Pod-Readme-0.110-11.el7 but it hasn't reached stable repo yet. [2] http://pkgs.fedoraproject.org/cgit/perl-Pod-Markdown.git Those modules are required in Makefile.PL, so BuildRequires should be put in place for them. Having Pod::Readme available allows the regeneration of the README file, which fixes the end-of-line issue noted by rpmlint. I think that BR can be added without causing you to miss out on anything? Pod-Markdown can be skipped as the resulting README.mkdn is not included in the RPM (correctly, as it is an exact copy of the README file) Is that ok? Yes, I think it would be okay here (with keeping Pod::Readme and dropping Pod::Markdown) since Pod::Readme will be available soon in all Fedora/RHEL scope. Okay, give me the new spec and SRPM file and i'll complete the review. Updated spec: http://www.fateyev.com/RPMS/Fedora20/testing/perl-DBIx-RunSQL.spec SRPM: http://www.fateyev.com/RPMS/Fedora20/testing/SRPMS/perl-DBIx-RunSQL-0.12-2.fc20.denf.src.rpm Koji Rawhide build: https://koji.fedoraproject.org/koji/taskinfo?taskID=7791613 Builds ok at http://koji.fedoraproject.org/koji/taskinfo?taskID=7798953 rpmlint is clean Package APPROVED! New Package SCM Request ======================= Package Name: perl-DBIx-RunSQL Short Description: Run SQL commands from a file Owners: dfateyev Branches: f19 f20 f21 el5 el6 epel7 InitialCC: perl-sig Git done (by process-git-requests). perl-DBIx-RunSQL-0.12-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-DBIx-RunSQL-0.12-2.fc21 perl-DBIx-RunSQL-0.12-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-DBIx-RunSQL-0.12-2.fc20 perl-DBIx-RunSQL-0.12-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-DBIx-RunSQL-0.12-2.fc19 perl-DBIx-RunSQL-0.12-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-DBIx-RunSQL-0.12-2.el7 perl-DBIx-RunSQL-0.12-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-DBIx-RunSQL-0.12-2.el6 perl-DBIx-RunSQL-0.12-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-DBIx-RunSQL-0.12-2.el5 perl-DBIx-RunSQL-0.12-2.fc19 has been pushed to the Fedora 19 testing repository. perl-DBIx-RunSQL-0.12-2.fc20 has been pushed to the Fedora 20 stable repository. perl-DBIx-RunSQL-0.12-2.fc19 has been pushed to the Fedora 19 stable repository. perl-DBIx-RunSQL-0.12-2.el6 has been pushed to the Fedora EPEL 6 stable repository. perl-DBIx-RunSQL-0.12-2.el7 has been pushed to the Fedora EPEL 7 stable repository. perl-DBIx-RunSQL-0.12-2.el5 has been pushed to the Fedora EPEL 5 stable repository. perl-DBIx-RunSQL-0.12-2.fc21 has been pushed to the Fedora 21 stable repository. |