Bug 1141528 (mnemo)
| Summary: | Review Request: php-horde-mnemo - A web based notes manager | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||||
| Component: | Package Review | Assignee: | Shawn Iwinski <shawn> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | package-review, shawn | ||||||
| Target Milestone: | --- | Flags: | shawn:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | php-horde-mnemo-4.2.3-1.el7 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2014-12-20 08:33:26 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 1141526 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Remi Collet
2014-09-14 12:55:33 UTC
Update to 4.2.2 https://github.com/remicollet/remirepo/commit/e3ab9235fe16d38d01ca707ffce23a1d99746295 Spec: https://raw.githubusercontent.com/remicollet/remirepo/e3ab9235fe16d38d01ca707ffce23a1d99746295/php/horde/php-horde-mnemo/php-horde-mnemo.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-mnemo-4.2.2-1.remi.src.rpm Update to 4.2.3 (security) https://github.com/remicollet/remirepo/commit/2a1d024c443081812cd205c3b0f8462aa1186272 Spec: https://raw.githubusercontent.com/remicollet/remirepo/2a1d024c443081812cd205c3b0f8462aa1186272/php/horde/php-horde-mnemo/php-horde-mnemo.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-mnemo-4.2.3-1.remi.src.rpm Created attachment 965619 [details]
phpcompatinfo.log
phpcompatinfo version 2.26.0
Created attachment 965620 [details]
fedora-review.txt
Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -b 1141528
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[!]: Buildroot is not present
Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
As usual, remove EPEL 5 bits after initial import.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
W: conffile-without-noreplace-flag /etc/horde/mnemo/conf.xml
%attr(0660,apache,apache) %config %{_sysconfdir}/horde/%{pear_name}/*.xml
Since the permission of this config file is 0660 instead of 0640, it
implies that this file can be edited by end-users. However, without
"%config(noreplace)" end-users' edits would be lost.
Just a warning, but you may want to address this.
No blockers.
===== APPROVED =====
Thanks again! The xml file is not config file, but reference file used to generate the real config (*.php). I will fix the perm. New Package SCM Request ======================= Package Name: php-horde-mnemo Short Description: A web based notes manager Upstream URL: http://www.horde.org/apps/mnemo Owners: remi Branches: f20 f21 el6 epel7 InitialCC: Git done (by process-git-requests). php-horde-mnemo-4.2.3-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/php-horde-mnemo-4.2.3-1.el7 php-horde-mnemo-4.2.3-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-mnemo-4.2.3-1.el6 php-horde-mnemo-4.2.3-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-horde-mnemo-4.2.3-1.fc21 php-horde-mnemo-4.2.3-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-horde-mnemo-4.2.3-1.fc20 php-horde-mnemo-4.2.3-1.el7 has been pushed to the Fedora EPEL 7 testing repository. php-horde-mnemo-4.2.3-1.fc21 has been pushed to the Fedora 21 stable repository. php-horde-mnemo-4.2.3-1.fc20 has been pushed to the Fedora 20 stable repository. php-horde-mnemo-4.2.3-1.el6 has been pushed to the Fedora EPEL 6 stable repository. php-horde-mnemo-4.2.3-1.el7 has been pushed to the Fedora EPEL 7 stable repository. |