Bug 1141577

Summary:	package contains embedded private copy of valgrind.h
Product:	[Fedora] Fedora	Reporter:	Mark Wielaard <mjw>
Component:	mingw-glib2	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	amigadave, erik-fedora, fedora-mingw, fedora, kalevlember, lfarkas, marcandre.lureau, rjones
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-09-17 12:27:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1141461

Description Mark Wielaard 2014-09-14 22:03:01 UTC

This package appears to include a private copy of valgrind.h. In the latest relase of valgrind 3.10.0 a bug was fixed for ppc32 and support was added for aarch64 and ppc64le. Please either update the private copy of valgrind.h (memcheck.h, callgrind.h, etc) or (better) make your package BuildRequires: valgrind-devel and use the system installed headers.

Comment 1 David King 2014-09-17 12:27:23 UTC

This was already fixed in http://pkgs.fedoraproject.org/cgit/mingw-glib2.git/commit/?id=3286bb7eaf13c82319a01d36b764ac85f1bb8f0a and the fix is included in upstream releases (which are also in Rawhide) from 2.41.2 onwards.

Comment 2 Mark Wielaard 2014-09-17 13:16:10 UTC

Note that isn't the actual upstream valgrind.h from 3.10.0 but a snapshot from svn. In particular it is missing ppc64le support. Could you double check that the final valgrind.h from valgrind 3.10.0 has really been incorporated?

Comment 3 David King 2014-09-17 13:33:19 UTC

I do not think that ppc64le support is too relevant to a MinGW package. ;-) The updated header from SVN was needed for a win64-specific fix.

The upstream bug report to get valgrind.h updated for GLib is https://bugzilla.gnome.org/show_bug.cgi?id=736741 (which is more relevant to the glib2 package and bug 1141471, not this mingw package).