Bug 1141880
Summary: | Review Request: golang-googlecode-gcfg - Gcfg reads INI-style configuration files into Go structs | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jan Chaloupka <jchaloup> |
Component: | Package Review | Assignee: | Lokesh Mandvekar <lsm5> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | lsm5, package-review |
Target Milestone: | --- | Flags: | lsm5:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | golang-googlecode-gcfg-0-0.4.gitc2d3050.el6 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-09-24 09:12:42 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1122176 |
Description
Jan Chaloupka
2014-09-15 16:02:56 UTC
Jan, could you also please post koji scratch build url and rpmlint output, kinda like: Bug 1140495 ohh btw, I've been building all kubernetes deps (almost done). I could send the modified specs for all packages in a pull request to you, and review and approve all BZs pretty much in 1 shot. How does that sound? Hello, Lokesh, thanks for all those package being reviewed :). I will prepare all srpm and modified spec files after rpmlint on my fedorapeople page. So we does not have to make a pull request for each change. When all spec files are ok to go, then we can make one big pull request for all of them :). I was hoping I will make all srpms and rpmlint outputs yesterday :). Working on it right now. You have been building kubernetes deps from these reviews or before it? Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-googlecode-gcfg/golang-googlecode-gcfg.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-googlecode-gcfg/golang-googlecode-gcfg-0.0.0-0.2.gitc2d3050044d0.fc21.src.rpm Description: Gcfg reads INI-style configuration files into Go structs $ rpmlint /root/rpmbuild/SRPMS/golang-googlecode-gcfg-0.0.0-0.2.gitc2d3050044d0.fc21.src.rpm /root/rpmbuild/RPMS/x86_64/golang-googlecode-gcfg-devel-0.0.0-0.2.gitc2d3050044d0.fc21.x86_64.rpm golang-googlecode-gcfg.spec golang-googlecode-gcfg.src: W: spelling-error Summary(en_US) structs -> struts, instructs, destructs golang-googlecode-gcfg.src: W: spelling-error %description -l en_US structs -> struts, instructs, destructs golang-googlecode-gcfg-devel.x86_64: W: spelling-error Summary(en_US) systemd -> systems, system, system d golang-googlecode-gcfg-devel.x86_64: W: spelling-error %description -l en_US systemd -> systems, system, system d 2 packages and 1 specfiles checked; 0 errors, 4 warnings. Initial work by Eric Paris Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7589692 Changes applied Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-googlecode-gcfg/golang-googlecode-gcfg.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-googlecode-gcfg/golang-googlecode-gcfg-0-0.2.gitc2d3050.fc21.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7613221 Thanks LGTM. Specfile follows golang package guidelines as per the draft here: https://fedoraproject.org/wiki/PackagingDrafts/Go New Package SCM Request ======================= Package Name: golang-googlecode-gcfg Short Description: Gcfg reads INI-style configuration files into Go structs Upstream URL: https://code.google.com/p/gcfg/ Owners: jchaloup lsm5 vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig Git done (by process-git-requests). golang-googlecode-gcfg-0-0.2.gitc2d3050.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-gcfg-0-0.2.gitc2d3050.fc20 golang-googlecode-gcfg-0-0.2.gitc2d3050.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-googlecode-gcfg-0-0.2.gitc2d3050.fc21 golang-googlecode-gcfg-0-0.2.gitc2d3050.fc21 has been pushed to the Fedora 21 stable repository. golang-googlecode-gcfg-0-0.2.gitc2d3050.fc20 has been pushed to the Fedora 20 stable repository. golang-googlecode-gcfg-0-0.4.gitc2d3050.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-gcfg-0-0.4.gitc2d3050.fc20 golang-googlecode-gcfg-0-0.4.gitc2d3050.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-googlecode-gcfg-0-0.4.gitc2d3050.fc21 golang-googlecode-gcfg-0-0.4.gitc2d3050.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-gcfg-0-0.4.gitc2d3050.el6 golang-googlecode-gcfg-0-0.4.gitc2d3050.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. golang-googlecode-gcfg-0-0.4.gitc2d3050.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. golang-googlecode-gcfg-0-0.4.gitc2d3050.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |