Bug 1142051
| Summary: | Review Request: nodejs-xmldom - A W3C Standard XML DOM implementation and parser | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Parag Nemade <pnemade> |
| Component: | Package Review | Assignee: | T.C. Hollingsworth <tchollingsworth> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, tchollingsworth |
| Target Milestone: | --- | Flags: | tchollingsworth:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | nodejs-xmldom-0.1.19-1.1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-11-01 17:16:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 956806 | ||
|
Description
Parag Nemade
2014-09-16 05:24:16 UTC
Moved to new location Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-xmldom.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-xmldom-0.1.19-1.fc21.src.rpm > %check
> %nodejs_symlink_deps --check
This is pointless unless you actually execute something below it. For extra credit please add "BuildRequires: proof" and the test command `proof test */*/*.t.js` and comment it out or disable it all with a macro. This way, the tests can be easily enabled later on if someone packages proof.
Everything else is legit and test issues are a SHOULD so APPROVED.
Thanks T.C. Hollingsworth for this package review. I will follow your advice after importing the approved srpm. New Package SCM Request ======================= Package Name: nodejs-xmldom Short Description: A W3C Standard XML DOM implementation and parser Upstream URL: https://github.com/jindw/xmldom Owners: pnemade Branches: f20 f21 epel7 Git done (by process-git-requests). nodejs-xmldom-0.1.19-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-xmldom-0.1.19-1.fc20 nodejs-xmldom-0.1.19-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-xmldom-0.1.19-1.el7 nodejs-xmldom-0.1.19-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-xmldom-0.1.19-1.fc21 nodejs-xmldom-0.1.19-1.fc21 has been pushed to the Fedora 21 testing repository. Package Change Request ====================== Package Name: nodejs-chainsaw New Branches: f19 el6 Owners: pnemade oops corrected now Package Change Request ====================== Package Name: nodejs-xmldom New Branches: f19 el6 Owners: pnemade Git done (by process-git-requests). nodejs-xmldom-0.1.19-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-xmldom-0.1.19-1.fc19 nodejs-xmldom-0.1.19-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-xmldom-0.1.19-1.el6 nodejs-xmldom-0.1.19-1.1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-xmldom-0.1.19-1.1.el6 nodejs-xmldom-0.1.19-1.fc21 has been pushed to the Fedora 21 stable repository. nodejs-xmldom-0.1.19-1.fc20 has been pushed to the Fedora 20 stable repository. nodejs-xmldom-0.1.19-1.fc19 has been pushed to the Fedora 19 stable repository. nodejs-xmldom-0.1.19-1.el7 has been pushed to the Fedora EPEL 7 stable repository. nodejs-xmldom-0.1.19-1.1.el6 has been pushed to the Fedora EPEL 6 stable repository. |