Bug 1142098

Summary: hosted engine setup doesn't detect volume creation failures
Product: [Retired] oVirt Reporter: Sandro Bonazzola <sbonazzo>
Component: ovirt-hosted-engine-setupAssignee: Sandro Bonazzola <sbonazzo>
Status: CLOSED CURRENTRELEASE QA Contact: Elad <ebenahar>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.5CC: acanan, amureini, bugs, danken, dfediuck, didi, ecohen, gklein, istein, lsurette, lveyde, msivak, rbalakri, sbonazzo, stirabos, yeylon
Target Milestone: ---   
Target Release: 3.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: integration
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Thanks to the migration from vdsClient to vdscli API it is now possible to detect volume creation failures properly.
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-11-04 13:55:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1234915    
Attachments:
Description Flags
logs none

Description Sandro Bonazzola 2014-09-16 07:40:20 UTC
Not sure about what changed in HA or VDSM but now when I try to deploy hosted engine on iSCSI I have:

{'status': {'message': "Logical volume does not exist: ('59fbe5c7-3f29-4149-8595-fa6fb60b2965/688bc33b-5da4-4072-bd74-0dee60f1c940',)", 'code': 610}}

Since the setup part has not been changed, opening this bug down in the chain.

Comment 1 Sandro Bonazzola 2014-09-16 07:45:22 UTC
Created attachment 937885 [details]
logs

Comment 2 Sandro Bonazzola 2014-09-16 09:35:44 UTC
Looks like it was a bad vdsm error handling by setup. It failed to create a volume with size of 25GB in a iscsi lun of 26GB due to insufficient space but the error has not been detected by the setup.

Reducing severity and priority and drop blocking.

Comment 3 Sandro Bonazzola 2014-09-16 09:37:16 UTC
Just a note for remembering what need to be changed:

        status, message = serv.createVolume([
            sdUUID,
            spUUID,
            imgUUID,
            self.environment[ohostedcons.StorageEnv.IMAGE_SIZE_GB],
            volFormat,
            preallocate,
            diskType,
            volUUID,
            self.environment[ohostedcons.StorageEnv.IMAGE_DESC],
        ])

it returns status = 0 also if it failed creating the volume.
Need to change this code for using API instead of vdsClient.

Comment 4 Sandro Bonazzola 2014-12-01 07:16:17 UTC
Moving to 3.6 since the solution uses refactored code for using API instead of CLI

Comment 5 Sandro Bonazzola 2015-02-20 11:08:10 UTC
Automated message: can you please update doctext or set it as not required?

Comment 6 Nikolai Sednev 2015-05-31 18:23:39 UTC
Hi Sandro,
Please provide exact reproduction steps.

Comment 7 Sandro Bonazzola 2015-06-04 07:48:27 UTC
(In reply to Nikolai Sednev from comment #6)
> Hi Sandro,
> Please provide exact reproduction steps.

See comment #2.
try to create a volume with size of 25GB in a iscsi lun of 26GB: it should detect insufficient space and properly handle it.

Comment 8 Elad 2015-06-04 10:42:31 UTC
An attempt to deploy the hosted-engine image on a LUN that doesn't have enough capacity (tried on a 26G LUN) is detected and handled well:


[WARNING] Not enough free space, about 21 GiB are available
          Please specify the disk size of the VM in GB [Defaults to minimum requirement: 25]: 


Verified using:
ovirt-hosted-engine-setup-1.3.0-0.0.master.20150518075146.gitdd9741f.el7.noarch

Comment 9 Sandro Bonazzola 2015-11-04 13:55:28 UTC
oVirt 3.6.0 has been released on November 4th, 2015 and should fix this issue.
If problems still persist, please open a new BZ and reference this one.