Bug 1142178

Summary: virt-customize: No error messages output if append '--format qcow2' after '-a guest.img', guest.img is a raw format image file
Product: Red Hat Enterprise Linux 7 Reporter: Lingfei Kong <lkong>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 7.1CC: leiwang, lkong, mbooth, ptoscano, wshi
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libguestfs-1.27.47-1.1.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-03-05 13:45:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Lingfei Kong 2014-09-16 10:04:19 UTC
Description of problem:
No error messages output if append '--format qcow2' after '-a guest.img', but if i put '--format qcow2' before '-a guest.img', virt-customize will detect the image format and print a error.


Version-Release number of selected component (if applicable):
libguestfs-1.27.43-1.1.el7


How reproducible:
100%


Steps to Reproduce:
1. Create a raw format guest image: rhel6.6.img
2. #virt-customize  --hostname unused -a rhel6.6.img --format qcow2
[   0.0] Examining the guest ...
[   5.0] Setting a random seed
[   5.0] Setting the hostname: unused
[   5.0] Finishing off

3. virt-customize  --format qcow2 --hostname unused -a rhel6.6.img
[   0.0] Examining the guest ...
virt-customize: error: libguestfs error: could not create appliance through
libvirt.

Try running qemu directly without libvirt using this environment variable:
export LIBGUESTFS_BACKEND=direct

Original error from libvirt: internal error: process exited while
connecting to monitor: Warning: option deprecated, use lost_tick_policy
property of kvm-pit instead.
qemu-kvm: -drive
file=/root/rhel6.6.img,if=none,id=drive-scsi0-0-0-0,format=qcow2,cache=writeback,discard=unmap:
could not open disk image /root/rhel6.6.img: Image is not in qcow2 format
 [code=1 domain=10]

If reporting bugs, run virt-customize with debugging enabled and include
the complete output:

  virt-customize -v -x [...]


Actual results:
Step 2 have no message output, it seems virt-customize use auto-detection model even though you append '--format qcow2' at the end of the command line.

Expected results:
Step 2 have a error message output, because you specify '--format qcow2', but guest.img is a raw format file

Additional info:

Comment 2 Richard W.M. Jones 2014-09-16 15:34:01 UTC
This is supposed to be fixed in >= 1.27.45.  Please try a more
recent version.

Upstream fix commit b7bdb63d8967762a5b234049c4dda911150cc199.

Comment 3 Lingfei Kong 2014-09-16 17:31:14 UTC
(In reply to Richard W.M. Jones from comment #2)
> This is supposed to be fixed in >= 1.27.45.  Please try a more
> recent version.
> 
> Upstream fix commit b7bdb63d8967762a5b234049c4dda911150cc199.

I test it against libguestfs-1.27.46-1.1.el7


#virt-customize  --hostname unused -a rhel7.0.img --format qcow2
virt-customize: error: --format parameter must appear before -a parameter

If reporting bugs, run virt-customize with debugging enabled and include 
the complete output:

  virt-customize -v -x [...]


So, it is fixed in libguestfs-1.27.46-1.1.el7, thanks for your repair work!

Comment 4 Richard W.M. Jones 2014-09-16 17:45:12 UTC
Setting flags so I can add this to the erratum ...

Comment 6 Lingfei Kong 2014-10-22 06:45:14 UTC
Verify with libguestfs-1.28.1-1.2.el7

Steps to verify:
#virt-customize --hostname unused -a rhel.img --format qcow2
virt-customize: error: --format parameter must appear before -a parameter

If reporting bugs, run virt-customize with debugging enabled and include 
the complete output:

  virt-customize -v -x [...]
#virt-customize --hostname unused -a rhel.img --format raw
virt-customize: error: --format parameter must appear before -a parameter

If reporting bugs, run virt-customize with debugging enabled and include 
the complete output:

  virt-customize -v -x [...]

Comment 8 errata-xmlrpc 2015-03-05 13:45:04 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0303.html