Bug 1142186

Summary:	virt-sysprep option '--mount-options' don't work well
Product:	Red Hat Enterprise Linux 7	Reporter:	Lingfei Kong <lkong>
Component:	libguestfs	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	low	Docs Contact:
Priority:	low
Version:	7.1	CC:	leiwang, mbooth, ptoscano, wshi
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libguestfs-1.27.47-1.1.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-03-05 13:45:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lingfei Kong 2014-09-16 10:18:45 UTC

Description of problem:
virt-sysprep option '--mount-options' don't work well.


Version-Release number of selected component (if applicable):
libguestfs-1.27.39-1.1.el7


How reproducible:
100%


Steps to Reproduce:
1. Create a raw format guest image: rhel6.6.img
2. Start the guest, and check in the guest:
# cat /etc/fstab
/dev/mapper/VolGroup-lv_root /                       ext4    defaults        1 1
.....

# mount | grep root
/dev/mapper/VolGroup-lv_root on / type ext4 (rw)

3. #virt-sysprep --mount-options "/:noatime" -a rhel6.6.img
4. Start the guest, check in the guest:
# cat /etc/fstab
/dev/mapper/VolGroup-lv_root /                       ext4    defaults        1 1
.....

# mount | grep root
/dev/mapper/VolGroup-lv_root on / type ext4 (rw)


Actual results:
The mount option field is still default in file /etc/fstab and in the output of 'mount | grep root'


Expected results:
The mount option field should be noatime in file /etc/fstab and in the output of 'mount | grep root', like(I assume that --mount-options implement this function by change file /etc/fstab):
# cat /etc/fstab
/dev/mapper/VolGroup-lv_root /                       ext4    noatime        1 1
.....

# mount | grep root
/dev/mapper/VolGroup-lv_root on / type ext4 (rw,noatime)

Additional info:

Comment 2 Richard W.M. Jones 2014-09-16 15:47:44 UTC

I guess the documentation is a bit unclear.

--mount-options has no effect in the disk image.  It's simply to
allow you to specify mount options for libguestfs when it opens the
disk image (mainly to support FreeBSD guests).

I have added this commit to clarify the documentation:

https://github.com/libguestfs/libguestfs/commit/f722571c73d427530a357b7a864a5432cc7db461

This will appear in libguestfs >= 1.27.48.

Comment 3 Richard W.M. Jones 2014-09-16 16:11:23 UTC

(In reply to Richard W.M. Jones from comment #2)
> This will appear in libguestfs >= 1.27.48.

I've added the patch on top of 1.27.47 in RHEL 7.1, so you should
see an improved man page in libguestfs-1.27.47-1.1.el7.

Comment 5 Lingfei Kong 2014-10-22 06:38:04 UTC

Verified with libguestfs-1.28.1-1.2.el7

Can find the following line in man virt-sysprep:
 --mount-options mp:opts[;mp:opts;...]
           Set the mount options used when libguestfs opens the disk image.  Note this has no effect on the
           guest.  It is used when opening certain guests such as ones using the UFS (BSD) filesystem.

           Use a semicolon-separated list of "mountpoint:options" pairs.  You may need to quote this list to
           protect it from the shell.

           For example:
           ......

Comment 7 errata-xmlrpc 2015-03-05 13:45:06 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0303.html