Bug 1142274

Summary: use of --onpart leads to traceback
Product: [Fedora] Fedora Reporter: Gene Czarcinski <gczarcinski>
Component: anacondaAssignee: David Lehman <dlehman>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 21CC: anaconda-maint-list, awilliam, g.kaviyarasu, jonathan, samuel-rhbugs, vanmeeuwen+fedora
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: anaconda-21.48.8-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-10-11 17:42:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
anaconda-tb
none
anaconda.log
none
storage.log none

Description Gene Czarcinski 2014-09-16 13:19:57 UTC
Created attachment 938030 [details]
anaconda-tb

Description of problem:
Attempting to do a kickstart install it dies early.  Attaching TB, anaconda.log, and storage.log.  Here is the traceback:
--------------------------------------------------------------------------
anaconda 21.48.6-1 exception report
Traceback (most recent call first):
  File "/usr/lib64/python2.7/site-packages/pyanaconda/kickstart.py", line 1159, in execute
    size=size)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/kickstart.py", line 1014, in execute
    p.execute(storage, ksdata, instClass)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/kickstart.py", line 1927, in doKickstartStorage
    ksdata.partition.execute(storage, ksdata, instClass)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/storage.py", line 313, in _doExecute
    doKickstartStorage(self.storage, self.data, self.instclass)
  File "/usr/lib64/python2.7/threading.py", line 766, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/threads.py", line 227, in run
    threading.Thread.run(self, *args, **kwargs)
UnboundLocalError: local variable 'size' referenced before assignment
--------------------------------------------------------------------------

Version-Release number of selected component (if applicable):
Fedora 21 TC7 Server DVD with anaconda-21.48.6-1

How reproducible:
Every time

Comment 1 Gene Czarcinski 2014-09-16 13:20:36 UTC
Created attachment 938031 [details]
anaconda.log

Comment 2 Gene Czarcinski 2014-09-16 13:21:19 UTC
Created attachment 938032 [details]
storage.log

Comment 3 Adam Williamson 2014-09-17 05:08:19 UTC
So that line was changed from 'size=self.size)' to 'size=size)' in 41f87df183d174322aead7f0cd2fe98a914f54e9 , "Use blivet.size.Size for all size quantities."

Comment 4 Adam Williamson 2014-09-17 05:11:57 UTC
...but i dunno if that's the problem, and didn't mean to change the assignee, sigh, too tired.

Comment 5 Gene Czarcinski 2014-09-17 19:58:33 UTC
The 41f87df183d174322aead7f0cd2fe98a914f54e9 commit is pretty old (Dec 18 2013).  If this was a problem I am sure that someone would have noticed it sooner.  Something else has to have changed.

BTW, with RC1, if I remove all of the storage configuration from a kickstart config file so that I have to manually do it, the rest of the kickstart works fine.

Comment 6 Adam Williamson 2014-09-17 20:24:33 UTC
A kickstart with:

clearpart --all
autopart

also works (specifically, https://www.happyassassin.net/ks/oc/oc7-httpd-sqlite.ks ). So somewhere between that level of specificity and the level in your kickstart is the breakage, I guess.

Comment 7 Gene Czarcinski 2014-09-18 18:26:44 UTC
1. Same failure with RC1.

2. Eackj kickstart install does not "custom" storage configuration.  The same failure occurs with both BTRFS and LVM.

Comment 8 David Lehman 2014-09-19 18:53:37 UTC
Looks like it's triggered by the use of --onpart.

Comment 9 Samuel Sieb 2014-10-03 00:13:28 UTC
The kickstarts I'm using for F20 cause this issue with F21.  Yes, I use --onpart.

Comment 10 David Lehman 2014-10-06 16:49:21 UTC
Should be fixed in anaconda-21.48.8-1.

Comment 11 Gene Czarcinski 2014-10-06 19:46:29 UTC
Good!  I will create an updates.img 21.48.7-1->21.48.8-1 and git it a try.

Comment 12 Gene Czarcinski 2014-10-06 20:03:54 UTC
Nope.  Errors out with another error.  I will gather info but this looks like a completely different problem with LogVol.

BTW, I did not see any of the commits with RHBZ#1142274

Comment 13 Gene Czarcinski 2014-10-11 17:42:13 UTC
OK, things are working with anaconda-21.48.9-1 so I am closing this report.

Comment 14 Samuel Sieb 2014-10-11 18:15:32 UTC
Yes, F21 Beta TC3 worked for me.