Bug 1142367

Summary: libvirt %preun script is broken
Product: [Fedora] Fedora Reporter: Jerry James <loganjerry>
Component: libvirtAssignee: Libvirt Maintainers <libvirt-maint>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: agedosier, berrange, clalancette, eblake, itamar, jforbes, laine, libvirt-maint, veillard, virt-maint
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-09-17 16:09:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jerry James 2014-09-16 16:10:54 UTC
Description of problem:
While updating packages on a Rawhide box today:

...
  Cleanup    : libvirt-daemon-driver-storage-1.2.8-1.fc22.x86_64        130/189 
/var/tmp/rpm-tmp.w5Leu0: line 8: libvirtd.socket: command not found
error: %preun(libvirt-daemon-1.2.8-1.fc22.x86_64) scriptlet failed, exit status 127
Error in PREUN scriptlet in rpm package libvirt-daemon-1.2.8-1.fc22.x86_64
  Cleanup    : libvirt-daemon-1.2.8-1.fc22.x86_64                       131/189 
...
$ rpm -q --scripts libvirt-daemon
...
preuninstall scriptlet (using /bin/sh):
            
if [ $1 -eq 0 ] ; then 
        # Package removal, not upgrade 
        systemctl --no-reload disable \ > /dev/null 2>&1 || : 
        systemctl stop \ > /dev/null 2>&1 || : 
fi 
                libvirtd.socket \
                libvirtd.service \
                virtlockd.socket \
                virtlockd.service
...

The new version of the package has the same broken %preun script.

Version-Release number of selected component (if applicable):
libvirt-daemon-1.2.8-2.fc22.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Have a previous version of libvirt-daemon installed on a Rawhide box
2. yum upgrade libvirt-daemon
3.

Actual results:
The update fails because of an error in %preun.

Expected results:
Clean upgrade.

Additional info:

Comment 1 Eric Blake 2014-09-16 16:20:55 UTC
same as bug 1136736 for RHEL; fix is 

commit 6209454d5b10c2d89faab8a56b250f1569d823fe
Author: Jiri Denemark <jdenemar>
Date:   Wed Sep 3 10:51:14 2014 +0200

    spec: Fix preun script for daemon
    
    %systemd_preun macro cannot be split into several lines.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1136736
    
    Signed-off-by: Jiri Denemark <jdenemar>

Comment 2 Cole Robinson 2014-09-17 16:09:13 UTC
Fixed in libvirt-1.2.8-3.fc22