Bug 114249

Summary:	compile time problems
Product:	[Fedora] Fedora	Reporter:	d.binderman
Component:	gedit	Assignee:	Dan Williams <dcbw>
Status:	CLOSED UPSTREAM	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	1
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2004-10-15 12:55:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description d.binderman 2004-01-25 13:39:40 UTC

Description of problem:

I just tried to compile package gedit-2.4.0-3, from Redhat
Fedora Core 1.

The compiler said

1.

gedit-encodings-dialog.c(523): warning #140: too many arguments in
function call

The source code is

	update_list (dialog);

but, earlier in the same file

static void
update_list ()
{

Suggest remove parameter dialog.

2.

gedit-prefs-manager.c(323): remark #592: variable "color" is used
before its value is set

The source code is

        GdkColor color;

        gedit_debug (DEBUG_PREFS, "");

        g_return_val_if_fail (client != NULL, color);

Suggest initialise color before first use.



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Marco Pesenti Gritti 2004-10-15 12:55:54 UTC

Trivial patch UPSTREAM

http://bugzilla.gnome.org/show_bug.cgi?id=155499