Bug 1142842

Summary: nfsstat server unclear rpc stats
Product: [Fedora] Fedora Reporter: Marko Myllynen <myllynen>
Component: nfs-utilsAssignee: Steve Dickson <steved>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 21CC: bfields, jlayton, steved
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: nfs-utils-1.3.1-1.1.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-11-01 17:08:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Marko Myllynen 2014-09-17 13:48:25 UTC
Description of problem:
linux/net/sunrpc/stats.c has:

/*
 * Get RPC server stats
 */
void svc_seq_show(struct seq_file *seq, const struct svc_stat *statp) {
...
        seq_printf(seq,
                "rpc %u %u %u %u %u\n",
                        statp->rpccnt,
                        statp->rpcbadfmt+statp->rpcbadauth+statp->rpcbadclnt,
                        statp->rpcbadfmt,
                        statp->rpcbadauth,
                        statp->rpcbadclnt);
...

But when /proc/net/rpc/nfsd contains

rpc 1 2 3 4 5

nfsstat -sv prints:

Server rpc stats:
calls      badcalls   badclnt    badauth    xdrcall
1          2          3          4          5       

Shouldn't this be instead:

Server rpc stats:
calls      badcalls   badfmt     badauth    badclnt
1          2          3          4          5

Comment 1 Steve Dickson 2014-09-22 15:46:26 UTC
commit 0a7b6854e50eca6613f525c8e1b7978c10372863
Author: Steve Dickson <steved>
Date:   Tue Sep 16 09:10:55 2014 -0400

    Fixed typo in nfsstat -sv output
    
    Signed-off-by: Steve Dickson <steved>

Comment 3 Fedora Update System 2014-10-22 16:01:41 UTC
nfs-utils-1.3.1-1.0.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nfs-utils-1.3.1-1.0.fc21

Comment 4 Fedora Update System 2014-10-22 19:14:18 UTC
Package nfs-utils-1.3.1-1.0.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing nfs-utils-1.3.1-1.0.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-13484/nfs-utils-1.3.1-1.0.fc21
then log in and leave karma (feedback).

Comment 5 Fedora Update System 2014-10-27 08:18:07 UTC
Package nfs-utils-1.3.1-1.1.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing nfs-utils-1.3.1-1.1.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-13484/nfs-utils-1.3.1-1.1.fc21
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2014-11-01 17:08:34 UTC
nfs-utils-1.3.1-1.1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.