Bug 1142864

Summary: nmtui cannot change bond mode from active-backup to round-robin
Product: Red Hat Enterprise Linux 7 Reporter: Dan Williams <dcbw>
Component: NetworkManagerAssignee: Dan Winship <danw>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.1CC: danw, dcbw, jklimes, lrintel, thaller, vbenes, vhumpa
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: NetworkManager-0.9.9.1-46.git20140326.4dba720.el7 Doc Type: Bug Fix
Doc Text:
* Switching a network bond connection from "active-backup" mode to a different mode using the nmtui client failed to remove the interface option, creating an erroneous configuration that would be refused by the NetworkManager daemon. This update fixes the issue. (BZ#1142864)
 Story Points: ---
Clone Of: Environment:
Last Closed: 2015-03-05 13:53:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Suggested fix (el7)
none
[PATCH] tui: additional fix for 'primary' option
none
Revert none

Description Dan Williams 2014-09-17 14:22:54 UTC 
When you change a bond from active-backup (with a primary specified) and then change to round-robin, and attempt to save, you get the error:

Unable to save connection: bond.options: 'primary' option is only valid for 'mode=active-backup'

likely because the tui isn't clearing the bond options when the mode changes, or something like that.
Comment 2 Lubomir Rintel 2014-09-19 10:29:34 UTC 
Created attachment 939195 [details]
Suggested fix (el7)

Please review.

el7: (attached)
master: https://github.com/lkundrak/NetworkManager/commit/d75103375af79e71125fa312fd461358662d5fe2
Comment 3 Dan Winship 2014-09-19 13:31:39 UTC 
> Just drop is as we disable the widget in UI.

typo ("drop is")

I think you need to add the option back in the TRUE case as well; otherwise if you fill in a primary value, then change the mode and then change it back, the entry would still show the old value, but it wouldn't be set in the NMSettingBond.
Comment 4 Lubomir Rintel 2014-09-19 16:54:07 UTC 
Does this look better?

https://github.com/lkundrak/NetworkManager/commit/fd33ce5a5158b0fbce3d03959393274db7b4223d
Comment 5 Dan Winship 2014-09-19 19:44:16 UTC 
yes, that looks right
Comment 6 Dan Williams 2014-09-19 21:34:06 UTC 
Looks right to me too.  We may need to do this with other options too, but this fixes the immediate bug.
Comment 7 Jirka Klimes 2014-09-22 07:29:04 UTC 
The patch looks good to me.
Comment 8 Jirka Klimes 2014-09-22 09:03:17 UTC 
Committed upstream:
a36a3a9 tui/bond: remove primary option if mode is not active-backup (rh #1142864)
Comment 9 Jirka Klimes 2014-09-22 10:48:01 UTC 
We probably want to include these commits too:
2f36955 tui: fix displaying bond ARP IP targets
b0b51ec tui: don't call g_strv_length() on NULL
Comment 11 Jirka Klimes 2014-09-22 17:16:17 UTC 
Created attachment 940084 [details]
[PATCH] tui: additional fix for 'primary' option

Additional fix for primary option.

Note:
Commits form comment #9 are already contained in NetworkManager-0.9.9.1-40.git20140326.4dba720.el7
Comment 12 Dan Williams 2014-09-22 18:36:14 UTC 
(In reply to Jirka Klimes from comment #11)
> Created attachment 940084 [details]
> [PATCH] tui: additional fix for 'primary' option
> 
> Additional fix for primary option.
> 
> Note:
> Commits form comment #9 are already contained in
> NetworkManager-0.9.9.1-40.git20140326.4dba720.el7

Yeah, good catch.
Comment 13 Jirka Klimes 2014-09-23 08:41:24 UTC 
(In reply to Dan Williams from comment #12)
> (In reply to Jirka Klimes from comment #11)
> > Created attachment 940084 [details]
> > [PATCH] tui: additional fix for 'primary' option
> > 
> > Additional fix for primary option.
> > 
> > Note:
> > Commits form comment #9 are already contained in
> > NetworkManager-0.9.9.1-40.git20140326.4dba720.el7
> 
> Yeah, good catch.

Upstream:
37f1208 tui: additional fix for 'primary' option

Pushed to RHEL 7.1 too: NetworkManager-0.9.9.1-41.git20140326.4dba720.el7
Comment 14 Vitezslav Humpa 2014-09-23 10:40:02 UTC 
Looks like the 'Primary' option is mandatory for the whole form not depending just on Active Backup mode where it's visible. So it currently blocks the 'OK' trying to create a connection with any other mode. (NetworkManager-0.9.9.1-41)
Comment 16 Lubomir Rintel 2014-10-10 09:15:11 UTC 
Created attachment 945535 [details]
Revert

I've pushed incomplete fix to el7. This needs to be removed and replaced with a complete fix.
Comment 19 errata-xmlrpc 2015-03-05 13:53:17 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0311.html