Bug 1143032

Note the Source0 is still not ok, waiting on this thread:
https://lists.fedoraproject.org/pipermail/packaging/2014-September/010273.html

I tried to do a review, however, there are some fundamental issues with the package:

1. python-gssapi spec lacks dependencies of python-gssapi, namely python-cffi.

2. However, even adding BuildRequires: python-cffi doesn't help. python-gssapi uses PyPi infra and tries to download own dependencies from there and build them right in the build root.

3. I tried to use python-py2pack to generate correct fedora spec but that also failed. python-py2pack uses Python's xmlrpclib which doesn't handle HTTP's 301 Moved Permanently return code and simply raises an exception:
xmlrpclib.ProtocolError: <ProtocolError for python.org/pypi: 301 Moved Permanently>

Gah, I did not realize that it was trying to download unconditionally.

I'll see if we can patch to avoid that.

I uploaded a new spec file and srpm package at the same url.
There is now a patch that strips away the setup code use to download data from pypi and explicitly set a list of packages to build (for some reason in F20 setuptools does not include the find_packages module).
I also relaxed the cffi version to 0.6 and it seem to work, however I will remove that part when pushing to rawhide/F21 as there 0.8 is available.

Let me know if the approach looks sane, I will test it on rawhide asap and change spec/srpm accordingly (at least wrt cffi dependency).

Spec URL: https://simo.fedorapeople.org/reviews/python-gssapi.spec
SRPM URL: https://simo.fedorapeople.org/reviews/python-gssapi-0.6.4-1.fc20.src.rpm
Description: GSSAPI bindings for python
Fedora Account System Username: simo

The file names in the Urls were incorrect, let's see if fedora-review picks up later comments.

Uploaded new one with github Source0 url fixed with a working one.

Spec URL: https://fedorapeople.org/~sross/python-gssapi/python-gssapi.spec
SRPM URL: https://fedorapeople.org/~sross/python-gssapi/python-gssapi-1.0.0-1.fc23.src.rpm
Description: Python Bindings for GSSAPI (RFC 2743/2744 and extensions)
Fedora Account System Username: simo

Ok after a lot of work with have new python-gssapi packages that we reall want in Fedora (a derivation of the orginal ones we were reviewing).
Alexander, can you resume review with these new spec/srpms files ?

This is an unofficial review.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======

- You should add macro for the package name in the spec. 
    like in Source0: https://github.com/pythongssapi/python-gssapi/archive/v%{version}.tar.gz to https://github.com/pythongssapi/%{name}/archive/v%{version}.tar.gz

- Permissions on files are set properly.
  Note: See rpmlint output
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
- Package contains BR: python2-devel or python3-devel
    See : http://fedoraproject.org/wiki/Packaging:Python#BuildRequires


===== MUST items =====

C/C++:
[?]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 30 files have unknown license. Detailed output of
     licensecheck in /home/kushal/package-review-test/1143032-python-
     gssapi/licensecheck.txt
[?]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory names).
    Use Macro for package name in source0
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[?]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[?]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[!]: Package complies to the Packaging Guidelines
    Note : Use of depreceated macros. BuildArch missing
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[?]: Python eggs must not download any dependencies during the build process.
[?]: A package which is used by another package via an egg interface should
     provide egg info.
[!]: Package meets the Packaging Guidelines::Python
     Fix the macros , %{__python} is deprecated.
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
     - Tests are not present. Add check for tests
[?]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python-gssapi-1.0.0-1.fc23.x86_64.rpm
          python-gssapi-1.0.0-1.fc23.src.rpm
python-gssapi.x86_64: W: spelling-error %description -l en_US pythonic -> Python, python
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/ext_cred_store.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/chan_bindings.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/sec_contexts.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/ext_cred_imp_exp.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/cython_converters.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/mech_krb5.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/exceptions.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/oids.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/message.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/names.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/types.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/creds.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/ext_s4u.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/misc.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/ext_rfc5588.so 0775L
python-gssapi.src: W: spelling-error %description -l en_US pythonic -> Python, python
python-gssapi.src:9: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 9)
2 packages and 0 specfiles checked; 15 errors, 3 warnings.




Rpmlint (installed packages)
----------------------------
]0;<mock-chroot><mock-chroot>sh-4.3# rpmlint python-gssapi
python-gssapi.x86_64: W: spelling-error %description -l en_US pythonic -> Python, python
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/ext_cred_store.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/chan_bindings.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/sec_contexts.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/ext_cred_imp_exp.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/cython_converters.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/mech_krb5.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/exceptions.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/oids.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/message.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/names.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/types.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/creds.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/ext_s4u.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/misc.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/ext_rfc5588.so 0775L
1 packages and 0 specfiles checked; 15 errors, 1 warnings.
]0;<mock-chroot><mock-chroot>sh-4.3# echo 'rpmlint-done:'



Requires
--------
python-gssapi (rpmlib, GLIBC filtered):
    krb5-libs
    libc.so.6()(64bit)
    libcom_err.so.2()(64bit)
    libgssapi_krb5.so.2()(64bit)
    libgssapi_krb5.so.2(gssapi_krb5_2_MIT)(64bit)
    libk5crypto.so.3()(64bit)
    libkrb5.so.3()(64bit)
    libpthread.so.0()(64bit)
    libpython2.7.so.1.0()(64bit)
    python(abi)
    python-decorator
    python-enum34
    python-six
    rtld(GNU_HASH)



Provides
--------
python-gssapi:
    python-gssapi
    python-gssapi(x86-64)



Unversioned so-files
--------------------
python-gssapi: /usr/lib64/python2.7/site-packages/gssapi/raw/chan_bindings.so
python-gssapi: /usr/lib64/python2.7/site-packages/gssapi/raw/creds.so
python-gssapi: /usr/lib64/python2.7/site-packages/gssapi/raw/cython_converters.so
python-gssapi: /usr/lib64/python2.7/site-packages/gssapi/raw/exceptions.so
python-gssapi: /usr/lib64/python2.7/site-packages/gssapi/raw/ext_cred_imp_exp.so
python-gssapi: /usr/lib64/python2.7/site-packages/gssapi/raw/ext_cred_store.so
python-gssapi: /usr/lib64/python2.7/site-packages/gssapi/raw/ext_rfc5588.so
python-gssapi: /usr/lib64/python2.7/site-packages/gssapi/raw/ext_s4u.so
python-gssapi: /usr/lib64/python2.7/site-packages/gssapi/raw/mech_krb5.so
python-gssapi: /usr/lib64/python2.7/site-packages/gssapi/raw/message.so
python-gssapi: /usr/lib64/python2.7/site-packages/gssapi/raw/misc.so
python-gssapi: /usr/lib64/python2.7/site-packages/gssapi/raw/names.so
python-gssapi: /usr/lib64/python2.7/site-packages/gssapi/raw/oids.so
python-gssapi: /usr/lib64/python2.7/site-packages/gssapi/raw/sec_contexts.so
python-gssapi: /usr/lib64/python2.7/site-packages/gssapi/raw/types.so

Source checksums
----------------
https://github.com/pythongssapi/python-gssapi/archive/v1.0.0.tar.gz :
  CHECKSUM(SHA256) this package     : 7dd78e29267019c3f1a35e22aeb603a555f0cd3253a575999c4a433ab05a0793
  CHECKSUM(SHA256) upstream package : 7dd78e29267019c3f1a35e22aeb603a555f0cd3253a575999c4a433ab05a0793


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -b 1143032 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

I've updated the spec file and SRPM.  Currently, one of the requirements for running the tests is not packaged in Fedora, so the tests are disabled.  FWIW, we do run per-commit CI upstream.

The only comment I still have is to fix permissions:

python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/ext_cred_store.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/chan_bindings.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/sec_contexts.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/ext_cred_imp_exp.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/cython_converters.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/mech_krb5.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/exceptions.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/oids.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/message.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/names.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/types.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/creds.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/ext_s4u.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/misc.so 0775L
python-gssapi.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gssapi/raw/ext_rfc5588.so 0775L

Spec URL: https://fedorapeople.org/~sross/python-gssapi/python-gssapi.spec
SRPM URL: https://fedorapeople.org/~sross/python-gssapi/python-gssapi-1.1.0-1.fc23.src.rpm
Description: Python Bindings for GSSAPI (RFC 2743/2744 and extensions)
Fedora Account System Username: simo

I updated the spec file (fixes for permissions, new version, new Source0) and uploaded a new SRPM.

Thanks, Solly.

I don't have any additional comments anymore, the package seems to be fine.

Setting the review to +.

New Package SCM Request
=======================
Package Name: python-gssapi
Short Description: Python Bindings for GSSAPI (RFC 2743/2744 and extensions)
Upstream URL: https://github.com/pythongssapi/python-gssapi
Owners: simo sross
Branches: f22
InitialCC:

Git done (by process-git-requests).

python-gssapi-1.1.0-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/python-gssapi-1.1.0-1.fc22

Package python-gssapi-1.1.0-1.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing python-gssapi-1.1.0-1.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-5657/python-gssapi-1.1.0-1.fc22
then log in and leave karma (feedback).

python-gssapi-1.1.0-1.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.