Bug 114370

Summary: three compile time bugs
Product: [Fedora] Fedora Reporter: d.binderman
Component: gtkhtml2Assignee: Dave Malcolm <dmalcolm>
Status: CLOSED UPSTREAM QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 1   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2004-05-18 01:47:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
cosmetic patch none

Description d.binderman 2004-01-27 12:24:44 UTC
Description of problem:

I just tried to compile package gtkhtml2-2.4.0-1 from Redhat
Fedora Core 1.

The compiler said

1.


cssparser.c(576): remark #592: variable "term" is used before its
value is set

The source code is

                        css_value_list_append (list, term, list_sep);

Suggest make sure term is initialised before first use.

2.

htmlboxtext.c(725): warning #117: non-void function
"html_box_text_get_text" should return a value

The source code is

        g_return_if_fail (box != NULL);

Suggest add value to return statement.

3.

htmlboxblocktextaccessible.c(644): remark #592: variable "len" is used
before its value is sen

The source code is

       html_font_specification_get_all_attributes (font_spec, attrs,
0, len,
                                                    HTML_VIEW
(view)->magnification);

Suggest variable len is initialised before first use.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Bart Martens 2004-02-01 02:58:27 UTC
Created attachment 97399 [details]
cosmetic patch

Comment 2 Dave Malcolm 2004-05-05 21:37:05 UTC
Reported upstream into GNOME Bugzilla:
http://bugzilla.gnome.org/show_bug.cgi?id=141962


Comment 3 Dave Malcolm 2004-05-18 01:47:55 UTC
Fixed upstream (Note the errror in the suggested patch for
html_box_text_get_text)