Bug 1143853

Summary:	geo-rep: file with same name has diffrent gfid in master and slave
Product:	[Community] GlusterFS	Reporter:	Aravinda VK <avishwan>
Component:	geo-replication	Assignee:	Aravinda VK <avishwan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	mainline	CC:	bugs, khiremat
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.0beta1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1147420 (view as bug list)		Environment:
Last Closed:	2015-05-14 17:26:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1060683, 1146369, 1147433
Bug Blocks:	1147420

Description Aravinda VK 2014-09-18 07:09:58 UTC

Description of problem:
Editors like vi, RENAMES original file to temp name and then create the new file for data modification. Geo-rep fails to sync when temp files RENAME involved.

How reproducible:
Always.

Steps to Reproduce:
1. Create a file in master mount
2. Open the file in vi editor, modify and save it.

Actual results:
Geo-rep fails to sync the change, and file GFID in master will not match with GFID of slave.

Expected results:
GFID should match in both master and slave, and geo-rep should sync the changes.

Comment 1 Anand Avati 2014-09-18 08:22:20 UTC

REVIEW: http://review.gluster.org/8761 (geo-rep: fix same file different gfid in master and slave) posted (#1) for review on master by Aravinda VK (avishwan)

Comment 2 Anand Avati 2014-09-26 07:19:02 UTC

COMMIT: http://review.gluster.org/8761 committed in master by Venky Shankar (vshankar) 
------
commit 3c29c50cf60135245290133fbfed11aa3cf01e39
Author: Aravinda VK <avishwan>
Date:   Wed Sep 17 12:59:52 2014 +0530

    geo-rep: fix same file different gfid in master and slave
    
    While processing RENAME in changelog, if the file is unlinked
    in master, then geo-rep was sending UNLINK to slave instead of
    RENAME.
    
    If rsync job fails if one of the file failed to sync in the job.
    This patch adds logic to remove GFID from data list if the same
    changelog has UNLINK entry for it after the DATA. Or it removes
    those GFIDs during retry of changelogs processing.
    
    BUG: 1143853
    Change-Id: I982dc976397cd0ab676bb912583f66a28f821926
    Signed-off-by: Aravinda VK <avishwan>
    Reviewed-on: http://review.gluster.org/8761
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>
    Reviewed-by: Kotresh HR <khiremat>
    Reviewed-by: Venky Shankar <vshankar>
    Tested-by: Venky Shankar <vshankar>

Comment 3 Anand Avati 2014-09-29 08:30:00 UTC

REVIEW: http://review.gluster.org/8879 (geo-rep: fix same file different gfid in master and slave) posted (#1) for review on release-3.6 by Aravinda VK (avishwan)

Comment 4 Niels de Vos 2015-05-14 17:26:11 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:28:13 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:35:14 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user