Bug 1144033

Summary:	Review Request: perl-ExtUtils-CBuilder - Compile and link C code for Perl modules
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-ExtUtils-CBuilder-0.280219-1.fc22	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-10-27 06:35:57 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2014-09-18 13:44:31 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-ExtUtils-CBuilder/perl-ExtUtils-CBuilder.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-ExtUtils-CBuilder/perl-ExtUtils-CBuilder-0.280219-1.fc22.src.rpm
Description:
This module can build the C portions of Perl modules by invoking the
appropriate compilers and linkers in a cross-platform manner. It was motivated
by the Module::Build project, but may be useful for other purposes as well.

Fedora Account System Username: ppisar


This dual-lived modules have already been sub-packaged from perl.spec. I decided to restore upstream's version numbering as upstream has stuck to it for a few years. I will adjust the version in the perl.spec later.

Comment 1 Jitka Plesnikova 2014-09-25 11:28:21 UTC

Source is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
BuildRequires are ok
All tests pass

$ rpmlint ./perl-ExtUtils-CBuilder*
perl-ExtUtils-CBuilder.noarch: E: devel-dependency perl-devel
perl-ExtUtils-CBuilder.noarch: W: spelling-error %description -l en_US linkers -> linker, liners, clinkers
perl-ExtUtils-CBuilder.noarch: W: incoherent-version-in-changelog 0.280219-1 ['1:0.280219-1.fc22', '1:0.280219-1']
perl-ExtUtils-CBuilder.src: W: spelling-error %description -l en_US linkers -> linker, liners, clinkers
2 packages and 1 specfiles checked; 1 errors, 3 warnings.

TODO: Update version in changelog to contain Epoch -  1:0.280219-1
perl-devel dependency is correct.

$ rpm -qp --requires perl-ExtUtils-CBuilder-0.280219-1.fc22.noarch.rpm |sort |uniq -c
      1 perl(:MODULE_COMPAT_5.20.1)
      1 perl(Config)
      1 perl(Cwd)
      1 perl(DynaLoader)
      1 perl(ExtUtils::CBuilder::Base)
      1 perl(ExtUtils::CBuilder::Platform::Unix)
      1 perl(ExtUtils::Mksymlists) >= 6.30
      1 perl(File::Basename)
      1 perl(File::Path)
      1 perl(File::Spec) >= 3.13
      1 perl(File::Spec::Functions)
      1 perl(File::Temp)
      1 perl(IO::File)
      1 perl(IPC::Cmd)
      1 perl(Perl::OSType) >= 1
      1 perl(Text::ParseWords)
      1 perl(strict)
      1 perl(vars)
      1 perl(warnings)
      1 perl-devel
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are ok

rpm -qp --provides perl-ExtUtils-CBuilder-0.280219-1.fc22.noarch.rpm |sort |uniq -c
      1 perl(ExtUtils::CBuilder) = 0.280219
      1 perl(ExtUtils::CBuilder::Base) = 0.280219
      1 perl(ExtUtils::CBuilder::Platform::Unix) = 0.280219
      1 perl(ExtUtils::CBuilder::Platform::VMS) = 0.280219
      1 perl(ExtUtils::CBuilder::Platform::Windows) = 0.280219
      1 perl(ExtUtils::CBuilder::Platform::Windows::BCC) = 0.280219
      1 perl(ExtUtils::CBuilder::Platform::Windows::GCC) = 0.280219
      1 perl(ExtUtils::CBuilder::Platform::Windows::MSVC) = 0.280219
      1 perl(ExtUtils::CBuilder::Platform::aix) = 0.280219
      1 perl(ExtUtils::CBuilder::Platform::android) = 0.280219
      1 perl(ExtUtils::CBuilder::Platform::cygwin) = 0.280219
      1 perl(ExtUtils::CBuilder::Platform::darwin) = 0.280219
      1 perl(ExtUtils::CBuilder::Platform::dec_osf) = 0.280219
      1 perl(ExtUtils::CBuilder::Platform::linux) = 0.280206
      1 perl(ExtUtils::CBuilder::Platform::os2) = 0.280219
      1 perl-ExtUtils-CBuilder = 1:0.280219-1.fc22
Binary provides are ok

Please consider fixing 'TODO' item

Package is APPROVED

Comment 2 Petr Pisar 2014-10-23 14:17:34 UTC

New Package SCM Request
=======================
Package Name: perl-ExtUtils-CBuilder
Short Description: Compile and link C code for Perl modules
Upstream URL: http://search.cpan.org/dist/ExtUtils-CBuilder/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2014-10-23 15:03:39 UTC

Git done (by process-git-requests).

Comment 4 Petr Pisar 2014-10-24 13:29:16 UTC

Thank you for the review and the repository.

I'm waiting for unblocking this package <https://fedorahosted.org/rel-eng/ticket/6022>.

Comment 5 Petr Pisar 2014-10-29 15:20:18 UTC

Sub-package disabled in perl-5.20.1-311.fc22.