Bug 1144137

Summary: virt-inspector fails on Minix 3 guest
Product: [Community] Virtualization Tools Reporter: Richard W.M. Jones <rjones>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: NEW --- QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: ptoscano
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
virt-inspector -v -x output none

Description Richard W.M. Jones 2014-09-18 18:43:44 UTC 
Created attachment 939008 [details]
virt-inspector -v -x output

Description of problem:

Libguestfs fails to inspect Minix 3.  Note that Minix 3 uses
a NetBSD userspace, and libguestfs spots this (however probably
it should be more specialized and know specifically about Minix).

It generally fails because we don't map device names such
as /dev/c0d0p0s1 into libguestfs canonical device names.

Version-Release number of selected component (if applicable):

1.24.5

Steps to Reproduce:
1. virt-inspector -v -x -a minix

See attachment for output.

Additional info:

Reported by Assaf Gordon
https://www.redhat.com/archives/libguestfs/2014-September/msg00115.html
Comment 1 Pino Toscano 2014-09-19 14:43:47 UTC 
(In reply to Richard W.M. Jones from comment #0)
> Created attachment 939008 [details]
> virt-inspector -v -x output
> 
> Description of problem:
> 
> Libguestfs fails to inspect Minix 3.  Note that Minix 3 uses
> a NetBSD userspace, and libguestfs spots this (however probably
> it should be more specialized and know specifically about Minix).

Note that since commit aeb879247456c619040d3a01a47a08ffa14c03f7 (so libguestfs >= 1.27.15), the NetBSD detection checks for /netbsd, which of course does not exist on Minix (at least on the provided image). This means that it is no more detected as NetBSD, but as Linux (since it matches the generic checks for it).
Comment 2 Pino Toscano 2014-09-23 08:53:29 UTC 
https://github.com/libguestfs/libguestfs/commit/5b65d05d5a31415aaa6f284f73da745e0ee0408a
(part of libguestfs >= 1.27.53) introduces a basic introspection support for Minix, recognising the base OS, its version, and its hostname.

What still can be done is resolving the names of the Minix devices into appliance devices; http://www.minix3.org/manpages/html4/controller.html provides an explanation of them.