Bug 1144449
| Summary: | always fullscreen for SPICE-xpi | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Tomas Pelka <tpelka> | |
| Component: | ovirt-engine-userportal | Assignee: | Nobody <nobody> | |
| Status: | CLOSED DUPLICATE | QA Contact: | Pavel Novotny <pnovotny> | |
| Severity: | high | Docs Contact: | ||
| Priority: | high | |||
| Version: | 3.5.0 | CC: | dblechte, ecohen, gklein, iheim, jjongsma, lsurette, michal.skrivanek, mkalinin, mkrcmari, ofrenkel, rbalakri, Rhev-m-bugs, sherold, tjamrisk, tspeetje, uril, vehrlich, yeylon | |
| Target Milestone: | --- | |||
| Target Release: | 3.5.1 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | virt | |||
| Fixed In Version: | Doc Type: | Bug Fix | ||
| Doc Text: |
Copied from bug 1155764:
Cause: CONTROLLER_AUTO_DISPLAY_RES flag is always set when using the RHEVM portal. When CONTROLLER_AUTO_DISPLAY_RES is set the client is opened in full screen mode.
Consequence: Client is always opened in the full screen mode.
Fix: Ignore CONTROLLER_AUTO_DISPLAY_RES flag.
Result: Client is opened in full screen mode only when is set to full screen (CONTROLLER_SET_FULL_SCREEN flag is set)
|
Story Points: | --- | |
| Clone Of: | ||||
| : | 1149352 (view as bug list) | Environment: | ||
| Last Closed: | 2014-10-30 15:25:30 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1149352, 1155764 | |||
| Bug Blocks: | ||||
|
Description
Tomas Pelka
2014-09-19 12:13:03 UTC
I forgot to mention that I got this issue on: Client: Rhel7.1 Host: Rhel6.6 Guest: W7 64b Same here: Client RHEL6.6, spice-xpi-2.7-25.el6.x86_64 Guest Windows 7 32b Guys, could someone check if this behavior is reproducible also without guest tools? (I did a quick naive test with spice-xpi from fedora 20 and FF 32 and it seems ok.) Yes we can ... Without RHEV-Tools (3.5.2) it seems to work (also with spice-xpi) ... work means connect in window mode then 'Open in Full Screen' is not checked RHEV sends the correct value as well (fullscreen=0,admin_console=0, when tools _are installed_)
Then the XPI "logic" kicks in, note it's unchanged for a long time, at least 3.1:
SendValue(CONTROLLER_FULL_SCREEN,
(m_fullscreen == PR_TRUE ? CONTROLLER_SET_FULL_SCREEN : 0) |
(m_admin_console == PR_FALSE ? CONTROLLER_AUTO_DISPLAY_RES : 0));
so ultimately what's sent to SPICE is correct (CONTROLLER_FULL_SCREEN == 2)
there were some changes in the interpretation of this value in 3.3(3.4?) IIRC…so maybe that's it?
upstream virt-viewer has a fix for this: 7212c8745a4853e99e9a5a1473aa45ce141c2506 moving to 3.5.1 for now due to dependency on virt-viewer fix *** Bug 1147926 has been marked as a duplicate of this bug. *** (In reply to Tomas Pelka from comment #0) > Description of problem: > UserPortal passing always fullscreen=1 option, even if .vv file includes > fulscreen=0. > Ok now it seems to work, but only if you use *.vv file. Via XPI problem persists RHEVM 3.5.0-0.17.beta.el6ev *** This bug has been marked as a duplicate of bug 1149352 *** |