Bug 1144662
| Summary: | Review Request: nodejs-nsp-api - Node.js module for NSP API | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Parag Nemade <pnemade> |
| Component: | Package Review | Assignee: | Mosaab Alzoubi <moceap> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | moceap, package-review |
| Target Milestone: | --- | Flags: | moceap:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | nodejs-nsp-api-1.0.0-2.2.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-11-01 16:54:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 956806, 1144666 | ||
|
Description
Parag Nemade
2014-09-20 07:13:45 UTC
Moved to new location Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-nsp-api.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-nsp-api-1.0.0-1.fc21.src.rpm - I think that's better to make short summaries and enough information in description (They're NOT same) - Refer to (#nothing to build) ==== Otherwise Everything OK! Will you please suggest me how should I write description? I think there is nothing wrong in having both summary and description as same text. I think many packages are following this already. Something like (Node.js module for NSP) Thanks. Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-nsp-api.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-nsp-api-1.0.0-2.fc21.src.rpm ?? nodejs-nsp-api.noarch: W: dangling-symlink /usr/lib/node_modules/nsp-api/node_modules/request /usr/lib/node_modules/request The target of the symbolic link does not exist within this package or its file based dependencies. Verify spelling of the link target and that the target is included in a package in this package's dependency chain. That is what you will find with almost all nodejs packages in Fedora which adds extra BR: in addition to BR:node-packaging. See https://fedoraproject.org/wiki/Packaging:Node.js#Symlinking_Dependencies for more information. Also see some other nodejs module package reviews where such rpmlint messages was allowed. See bug 1071668 and bug 981807. * Rpmlint: Ignored warnings. * License: MIT * Binaries: None * Spec: Clean * Content: Clean * %check test: Pass * Node.js package: Noarch * Node.js packaging guideline: checked * CHECKSUM(MD5) this package: 6329ee5b20d71e751e1dd81aaf55b21d CHECKSUM(MD5) upstream package: 6329ee5b20d71e751e1dd81aaf55b21d ======== APPROVED New Package SCM Request ======================= Package Name: nodejs-nsp-api Short Description: Node.js module for NSP API Upstream URL: https://github.com/nodesecurity/nsp-api Owners: pnemade Branches: f20 f21 epel7 Git done (by process-git-requests). nodejs-nsp-api-1.0.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-nsp-api-1.0.0-2.fc21 nodejs-nsp-api-1.0.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-nsp-api-1.0.0-2.fc20 nodejs-nsp-api-1.0.0-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-nsp-api-1.0.0-2.el7 nodejs-nsp-api-1.0.0-2.fc21 has been pushed to the Fedora 21 testing repository. Package Change Request ====================== Package Name: nodejs-nsp-api New Branches: f19 el6 Owners: pnemade Git done (by process-git-requests). nodejs-nsp-api-1.0.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-nsp-api-1.0.0-2.fc19 nodejs-nsp-api-1.0.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-nsp-api-1.0.0-2.el6 nodejs-nsp-api-1.0.0-2.1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-nsp-api-1.0.0-2.1.el6 nodejs-nsp-api-1.0.0-2.fc21 has been pushed to the Fedora 21 stable repository. nodejs-nsp-api-1.0.0-2.fc20 has been pushed to the Fedora 20 stable repository. nodejs-nsp-api-1.0.0-2.fc19 has been pushed to the Fedora 19 stable repository. nodejs-nsp-api-1.0.0-2.2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-nsp-api-1.0.0-2.2.el6 nodejs-nsp-api-1.0.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. nodejs-nsp-api-1.0.0-2.2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |