Bug 1144744

Summary:	AFR: invalid deletion of entry from indices/xattrop directory
Product:	[Community] GlusterFS	Reporter:	Anuradha <atalur>
Component:	replicate	Assignee:	Anuradha <atalur>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.6.0	CC:	bugs, gluster-bugs, smohan
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.6.0beta1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1139230	Environment:
Last Closed:	2014-11-11 08:39:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1139230
Bug Blocks:

Description Anuradha 2014-09-20 10:32:07 UTC

+++ This bug was initially created as a clone of Bug #1139230 +++

Description of problem:
During an xattrop fop if the xattr is not populated, index entry corresponding to the file on which the xattrop is being performed gets deleted from indices/xattrop directory.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2014-09-08 09:13:14 EDT ---

REVIEW: http://review.gluster.org/8652 (index: Do not add/delete index file if xattr is empty) posted (#1) for review on master by Anuradha Talur (atalur)

--- Additional comment from Anand Avati on 2014-09-09 02:01:59 EDT ---

REVIEW: http://review.gluster.org/8652 (index: Do not add/delete index file if xattr is empty) posted (#2) for review on master by Anuradha Talur (atalur)

--- Additional comment from Anand Avati on 2014-09-12 05:11:23 EDT ---

REVIEW: http://review.gluster.org/8652 (cluster/afr: Set all the xattrs needed by index xlator) posted (#3) for review on master by Anuradha Talur (atalur)

--- Additional comment from Anand Avati on 2014-09-15 06:30:18 EDT ---

REVIEW: http://review.gluster.org/8652 (cluster/afr: Set all the xattrs needed by index xlator) posted (#4) for review on master by Anuradha Talur (atalur)

--- Additional comment from Anand Avati on 2014-09-16 06:08:07 EDT ---

REVIEW: http://review.gluster.org/8652 (cluster/afr: Set all the xattrs needed by index xlator) posted (#5) for review on master by Anuradha Talur (atalur)

--- Additional comment from Anand Avati on 2014-09-16 22:49:40 EDT ---

COMMIT: http://review.gluster.org/8652 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 6f5bb1bfc520a91d70a02a9c13104c798e2dba14
Author: Anuradha <atalur>
Date:   Mon Sep 8 18:32:04 2014 +0530

    cluster/afr: Set all the xattrs needed by index xlator
    
    Index xlator removes the index file from indices
    xattrop directory in case the value for keys sent
    are zero.
    
    If all the required keys are not set by afr
    then index file might be removed in an invalid
    way.
    
    With this change all the keys required by index
    xlator are set by afr such that invalid removal of
    files does not occur.
    
    Change-Id: Idbed0764a95157fd5cab8d6685057a43788fc7df
    BUG: 1139230
    Signed-off-by: Anuradha <atalur>
    Reviewed-on: http://review.gluster.org/8652
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>

Comment 1 Anand Avati 2014-09-20 11:31:03 UTC

REVIEW: http://review.gluster.org/8788 (cluster/afr: Set all the xattrs needed by index xlator) posted (#1) for review on release-3.6 by Anuradha Talur (atalur)

Comment 2 Anand Avati 2014-09-21 17:29:13 UTC

COMMIT: http://review.gluster.org/8788 committed in release-3.6 by Vijay Bellur (vbellur) 
------
commit ab305c30c11d7e1711d7c2cf005dbb46a50bf643
Author: Anuradha <atalur>
Date:   Mon Sep 8 18:32:04 2014 +0530

    cluster/afr: Set all the xattrs needed by index xlator
    
    	Backport of: http://review.gluster.org/8652
    
    Index xlator removes the index file from indices
    xattrop directory in case the value for keys sent
    are zero.
    
    If all the required keys are not set by afr
    then index file might be removed in an invalid
    way.
    
    With this change all the keys required by index
    xlator are set by afr such that invalid removal of
    files does not occur.
    
    Change-Id: I1b77904920c8566057415c52242179aec6a015e2
    BUG: 1144744
    Signed-off-by: Anuradha <atalur>
    Reviewed-on: http://review.gluster.org/8788
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Niels de Vos 2014-09-22 12:46:44 UTC

A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 4 Niels de Vos 2014-11-11 08:39:30 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users