Bug 1145621

Summary: [engine-backend] [blkio-support] size units are not corralated between webadmin and backend for storage QOS
Product: Red Hat Enterprise Virtualization Manager Reporter: Elad <ebenahar>
Component: ovirt-engineAssignee: Martin Sivák <msivak>
Status: CLOSED CURRENTRELEASE QA Contact: Elad <ebenahar>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.5.0CC: acanan, dfediuck, ecohen, gklein, iheim, lpeer, lsurette, mavital, oourfali, rbalakri, Rhev-m-bugs, sherold, yeylon
Target Milestone: ---   
Target Release: 3.5.0   
Hardware: x86_64   
OS: Unspecified   
Whiteboard: sla
Fixed In Version: org.ovirt.engine-root-3.5.0-22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-02-17 17:07:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: SLA RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1166182    
Bug Blocks:    
Attachments:
Description Flags
Screenshot and logs from engine and vdsm none

Description Elad 2014-09-23 11:35:00 UTC
Created attachment 940406 [details]
Screenshot and logs from engine and vdsm

Description of problem:
When creating a new rule of storage blkio QOS, the presented units are in Mbps which are Mega bits per seconds. 
Examing the XML request passed to VDSM after allocating a disk to the new rule in the log, shows that the the usnits are in bytes per second. 

Version-Release number of selected component (if applicable):
rhev3.5 vt3.1
rhevm-3.5.0-0.12.beta.el6ev.noarch

How reproducible:
Always

Steps to Reproduce:
1. Create a new QOS rule for storage in the DC. Specify "1" in the Mbps write field.
2. Attach the rule to a storage domain in the DC via the "storage" main tab in webadmin
3. Create a new VM with a disk attached. Pick the new disk profile. 
4. Start the VM


Actual results:
The XML of CreateVM is sent to VDSM with: 

2014-09-23 13:57:58,475 INFO

specParams={ioTune={write_bytes_sec=1}}


Expected results:
The units send to VDSM should be the same as specified by the user. 
Need also to take under consideration the difference between bits and bytes. 

Additional info:
Screenshot and logs from engine and vdsm

Comment 1 Elad 2014-12-08 08:37:21 UTC
ioTune now includes the right size units as requested by user:

For example, I set the new QOS rule with 10MB total and in the request to vdsm, saw:

u'ioTune': {u'total_bytes_sec': 10485760}}


Verified using rhev 3.5 vt13.1

Comment 2 Eyal Edri 2015-02-17 17:07:20 UTC
rhev 3.5.0 was released. closing.