Created attachment 940429[details]
Engine and vdsm logs
Description of problem:
When hotplugging a disk that has a non-default disk profile, the ioTune attribute is not passed in the hotplug call.
Version-Release number of selected component (if applicable):
rhev3.5 vt3.1
rhevm-3.5.0-0.12.beta.el6ev.noarch
How reproducible:
Always
Steps to Reproduce:
1. Create a new QOS rule for storage in the DC. Specify a value in bandwith or iops.
2. Attach the rule to a storage domain in the DC via the "storage" main tab in webadmin
3. Create a new VM with a disk attached. Pick the default disk profile (not the new one)
4. Start the VM
5. Attach a new disk to the VM with the new disk profile
Actual results:
In the hotplug call, ioTune attribute is not passed.
Thread-293::DEBUG::2014-09-23 16:08:35,216::vm::3876::vm.Vm::(hotplugDisk) vmId=`dfd358b0-fc92-4013-ac7d-673d238af30c`::Hotplug disk xml: <disk device="disk" snapshot="no" type="block">
<source dev="/rhev/data-center/00000002-0002-0002-0002-00000000009d/2e174ed7-92b4-4d9a-9d36-04cbd3c58365/images/3c4aee1a-ed5b-4fa7-9017-aa444b38b1ac/54c517a3-2d1a-4246-b72e-91c5b605779f"/>
<target bus="virtio" dev="vdd"/>
<serial>3c4aee1a-ed5b-4fa7-9017-aa444b38b1ac</serial>
<driver cache="none" error_policy="stop" io="native" name="qemu" type="raw"/>
</disk>
Expected results:
The ioTune attribute should be given to vdsm for hotplug disk like it does for CreateVM.
Additional info:
Engine and vdsm logs
ioTune attribute is now included in hotplug disk while hotplugging a disk that has a profile:
Thread-2726::DEBUG::2014-12-08 10:05:00,520::__init__::469::jsonrpc.JsonRpcServer::(_serveRequest) Calling 'VM.hotplugDisk' in bridge with {u'params': {u'vmId': u'c6bf4fdb-a33c-
46d3-9b5b-94e179769786', u'drive': {u'iface': u'virtio', u'format': u'cow', u'optional': u'false', u'volumeID': u'25d479bb-7ab5-4a84-8d4e-5558e766531a', u'imageID': u'21ee792e-d
ae3-4888-a94d-3245a6fe623a', u'specParams': {u'ioTune': {u'total_bytes_sec': 10485760}}, u'readonly': u'false', u'domainID': u'fd598696-6a4b-47ae-86f8-c8063dde5f68', u'deviceId'
: u'21ee792e-dae3-4888-a94d-3245a6fe623a', u'poolID': u'00000002-0002-0002-0002-0000000000cd', u'device': u'disk', u'shared': u'false', u'propagateErrors': u'off', u'type': u'di
sk'}}, u'vmID': u'c6bf4fdb-a33c-46d3-9b5b-94e179769786'}
Verified using rhev 3.5 vt13.1
Created attachment 940429 [details] Engine and vdsm logs Description of problem: When hotplugging a disk that has a non-default disk profile, the ioTune attribute is not passed in the hotplug call. Version-Release number of selected component (if applicable): rhev3.5 vt3.1 rhevm-3.5.0-0.12.beta.el6ev.noarch How reproducible: Always Steps to Reproduce: 1. Create a new QOS rule for storage in the DC. Specify a value in bandwith or iops. 2. Attach the rule to a storage domain in the DC via the "storage" main tab in webadmin 3. Create a new VM with a disk attached. Pick the default disk profile (not the new one) 4. Start the VM 5. Attach a new disk to the VM with the new disk profile Actual results: In the hotplug call, ioTune attribute is not passed. Thread-293::DEBUG::2014-09-23 16:08:35,216::vm::3876::vm.Vm::(hotplugDisk) vmId=`dfd358b0-fc92-4013-ac7d-673d238af30c`::Hotplug disk xml: <disk device="disk" snapshot="no" type="block"> <source dev="/rhev/data-center/00000002-0002-0002-0002-00000000009d/2e174ed7-92b4-4d9a-9d36-04cbd3c58365/images/3c4aee1a-ed5b-4fa7-9017-aa444b38b1ac/54c517a3-2d1a-4246-b72e-91c5b605779f"/> <target bus="virtio" dev="vdd"/> <serial>3c4aee1a-ed5b-4fa7-9017-aa444b38b1ac</serial> <driver cache="none" error_policy="stop" io="native" name="qemu" type="raw"/> </disk> Expected results: The ioTune attribute should be given to vdsm for hotplug disk like it does for CreateVM. Additional info: Engine and vdsm logs