Bug 1146106

Summary:	Pluto crashes after start when some ah algorithms are used
Product:	Red Hat Enterprise Linux 7	Reporter:	Jaroslav Aster <jaster>
Component:	libreswan	Assignee:	Paul Wouters <pwouters>
Status:	CLOSED ERRATA	QA Contact:	Jaroslav Aster <jaster>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	7.1	CC:	ksrot, pwouters, qe-baseos-security
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1146100	Environment:
Last Closed:	2015-03-05 10:22:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1114683, 1146100
Bug Blocks:

Description Jaroslav Aster 2014-09-24 13:12:55 UTC

In rhel7 I used libreswan-3.8-5.el7. I got same results as in openswan, but in libreswan there are no abort messages in log file.

+++ This bug was initially created as a clone of Bug #1146100 +++

Description of problem:

Pluto crashes after start when some ah algorithms are used. I found two id3 and null. It does not matter which ike is used.


Version-Release number of selected component (if applicable):

openswan-2.6.32-37.el6

How reproducible:

Always.

Steps to Reproduce:
1. Configure openswan with phase2=ah, phase2alg=id3 or phase2alg=null.
2. Start openswan.
3. After start you can see that pluto crashed.

Actual results:

Crash.

ABORT at /builddir/build/BUILD/openswan-2.6.32/lib/libopenswan/alg_info.c:98
ABORT at /builddir/build/BUILD/openswan-2.6.32/lib/libopenswan/alg_info.c:98


Expected results:

No crash.

Additional info:

config setup
    protostack=netkey
    plutodebug=all
    plutorestartoncrash=false
    plutostderrlog=/tmp/pluto.log

conn test
    left=<INITIATOR>
    right=<RESPONDER>
    authby=secret
    ikev2=no
    phase2=ah
    phase2alg=<ALG>
    auto=add

Comment 1 Paul Wouters 2014-09-24 19:34:07 UTC

phase2alg=null confirmed a bug. phase2alg=id13 is rejected from the parser and will not load or cause a crash.

Comment 3 Paul Wouters 2014-09-29 16:34:26 UTC

note we updated the list of bad/illegal algorithms that are not allowed

(for latest version see: https://github.com/libreswan/libreswan/blob/master/testing/lib/libswan/algparse.c)

> 	do_test("3des-null", PROTO_IPSEC_ESP); /* must have non-null auth */
> 	do_test("aes128-null", PROTO_IPSEC_ESP); /* must have non-null auth */
> 	do_test("aes_gcm-md5", PROTO_IPSEC_ESP); /* AEAD must have auth null */
> 	do_test("aes_gcm", PROTO_IPSEC_AH); /* is ESP only cipher */
> 	do_test("aes_ccm", PROTO_IPSEC_AH); /* is ESP only cipher */
> 	do_test("null", PROTO_IPSEC_AH); /* iAH cannot use null auth */

these are all addressed in upstream and will go into 3.11 today or tomorrow

Comment 5 Jaroslav Aster 2014-11-14 16:14:24 UTC

Hi Paul,

I need to be sure. AH with null is not supported and ESP with null is supported and id3 is not supported. Is it right?

I'm going to test these algs.

phase2=ah, phase2alg=id3, not supported
phase2=ah, phase2alg=null, not supported
phase2=esp, phase2alg=id3, not supported
phase2=esp, phase2alg=null, supported

Comment 6 Paul Wouters 2014-11-17 07:15:36 UTC

correct

Comment 9 errata-xmlrpc 2015-03-05 10:22:53 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0431.html