Bug 1146915

Summary: neutron-server service "reload" action "restart" the service
Product: Red Hat OpenStack Reporter: Pratik Pravin Bandarkar <pbandark>
Component: openstack-neutronAssignee: Jakub Libosvar <jlibosva>
Status: CLOSED ERRATA QA Contact: Alexander Stafeyev <astafeye>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.0CC: chrisw, felipe.alfaro, jlibosva, jschluet, lpeer, lyarwood, mlopes, nyechiel, oblaut, pbandark, tfreger, tvvcox, yeylon
Target Milestone: z5Keywords: ZStream
Target Release: 5.0 (RHEL 6)   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: openstack-neutron-2014.1.4-4.el6ost Doc Type: Bug Fix
Doc Text:
Previously, OpenStack Networking (neutron) services did not support the SIGHUP signal for reloading configuration files, even though the 'reload' action was set in an the script. Consequently, the 'reload' action did not send the SIGHUP signal, but restarted the service. This update addresses this issue by removing the 'reload' action from the init scripts. As a result, the 'reload' action is no longer present in the init scripts, and calling such action will not have any result. If you wish to retain the previous behavior, then use 'restart' instead.
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-09-10 11:51:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Change to all init scripts to remove reload action none

Description Pratik Pravin Bandarkar 2014-09-26 11:00:22 UTC
Description of problem:
from: /etc/init.d/neutron-server


reload() {
    restart
}



force_reload() {
    restart
}


restart() {
    stop
    start
}


stop() {
    echo -n $"Stopping $prog: "
    killproc -p $pidfile $prog
    retval=$?
    echo
    [ $retval -eq 0 ] && rm -f $lockfile
    return $retval
}

==

While reloading the service, it will be stopped and then it wll get started. If its not possible to dynamically reload all configuration files for neutron-* related services then the "reload" option should be removed to avoid confusion.

Version-Release number of selected component (if applicable):
openstack-neutron-2013.2.3-14.el6ost.noarch

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:
with the reload option, the service actually will get restarted. 

Expected results:
If its not possible to dynamically reload all configuration files for neutron-* related services then the "reload" option should be removed to avoid confusion.

Additional info:

Comment 5 Jakub Libosvar 2015-06-04 09:02:04 UTC
Created attachment 1034617 [details]
Change to all init scripts to remove reload action

Comment 7 Alexander Stafeyev 2015-08-27 06:36:13 UTC
rhel 6.6 
Icehouse openstack (5) 

[root@puma07 ~]# neutron-server service reload
usage: neutron-server [-h] [--config-dir DIR] [--config-file PATH] [--debug]
                      [--log-config-append PATH]
                      [--log-date-format DATE_FORMAT] [--log-dir LOG_DIR]
                      [--log-file PATH] [--log-format FORMAT] [--nodebug]
                      [--nouse-syslog] [--noverbose] [--state_path STATE_PATH]
                      [--syslog-log-facility SYSLOG_LOG_FACILITY]
                      [--use-syslog] [--verbose] [--version]
neutron-server: error: unrecognized arguments: service reload


from: /etc/init.d/neutron-server

}

restart() {
    stop
    start
}

reload() {
    restart
}

force_reload() {
    restart
}


openstack-neutron-2014.1.4-1.el6ost.noarch
python-neutron-2014.1.4-1.el6ost.noarch
openstack-neutron-ml2-2014.1.4-1.el6ost.noarch
python-neutronclient-2.3.4-3.el6ost.noarch
openstack-neutron-openvswitch-2014.1.4-1.el6ost.noarch

Comment 8 Jakub Libosvar 2015-08-27 08:21:47 UTC
(In reply to Alexander Stafeyev from comment #7)
> rhel 6.6 
> Icehouse openstack (5) 
> 
> [root@puma07 ~]# neutron-server service reload
> usage: neutron-server [-h] [--config-dir DIR] [--config-file PATH] [--debug]
>                       [--log-config-append PATH]
>                       [--log-date-format DATE_FORMAT] [--log-dir LOG_DIR]
>                       [--log-file PATH] [--log-format FORMAT] [--nodebug]
>                       [--nouse-syslog] [--noverbose] [--state_path
> STATE_PATH]
>                       [--syslog-log-facility SYSLOG_LOG_FACILITY]
>                       [--use-syslog] [--verbose] [--version]
> neutron-server: error: unrecognized arguments: service reload

You swapped words :) It should be:

service neutron-server reload

neutron-server is an executable for spawning neutron-server process that is called from SysV script.

Comment 9 Alexander Stafeyev 2015-08-27 08:31:08 UTC
Tnx,


[root@puma07 ~]# service neutron-server reload
Stopping neutron:                                          [  OK  ]
Starting neutron:                                          [  OK  ]



Seems the option still exists

Comment 10 Jakub Libosvar 2015-08-27 08:45:50 UTC
The reason is that older version openstack-neutron-2014.1.4-1.el6ost was used for this verification.

Comment 11 Alexander Stafeyev 2015-08-31 09:07:24 UTC
[root@puma09 ~]# rpm -qa |grep openstack-neutron
openstack-neutron-ml2-2014.1.5-2.el6ost.noarch
openstack-neutron-openvswitch-2014.1.5-2.el6ost.noarch
openstack-neutron-2014.1.5-2.el6ost.noarch
[root@puma09 ~]# service neutron-server reload
Usage: /etc/init.d/neutron-server {start|stop|status|restart|condrestart|try-restart|force-reload}

Comment 13 errata-xmlrpc 2015-09-10 11:51:08 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1755.html