Bug 1146932
| Summary: | Review Request: python-fontname - A lib for guessing font name | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Parag Nemade <pnemade> |
| Component: | Package Review | Assignee: | Mosaab Alzoubi <moceap> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | moceap, package-review |
| Target Milestone: | --- | Flags: | moceap:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-fontname-0.2.0-2.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-11-10 06:22:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1146931 | ||
| Bug Blocks: | |||
|
Description
Parag Nemade
2014-09-26 11:29:59 UTC
This is actually a tool. Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/fontname.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/fontname-0.2.0-1.fc21.src.rpm - I think that's good to back to python-fontname (nothing in %bin) - uSummary !!! - Complete Python3 packages or remove its lines Right. I think I mistakenly considered this as a tool while changing other packages. I have corrected it now. Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/python-fontname.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/python-fontname-0.2.0-1.fc21.src.rpm Line #44:
find -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python2}|'
Doesn't include Python3 support
Line #50:
echo ${_python3}
What need it?
Line #64:
%{python2_sitelib}/%{module_name}-%{version}-py2.?.egg-info
Is it better to use '*' instead of '?' ?
Fixed above issues. Using '?' should not create any problem as generally egg-info files gets named as modulename-py2.7.egg-info or modulename-py3.4.egg-info and ? replaces one character. Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/python-fontname.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/python-fontname-0.2.0-2.fc21.src.rpm It almost done .
-----
When enable Python3 getting these errors:
RPM build errors:
Installed (but unpackaged) file(s) found:
/usr/lib/python3.3/site-packages/__pycache__/fontname.cpython-33.pyc
/usr/lib/python3.3/site-packages/__pycache__/fontname.cpython-33.pyo
Also in BRs for Python3 , Is python-freetype still like this?
Thanks for catching this. I should really test python3 subpackage by enabling it before posting updated package. The reason this got missed is because there is no module directory getting installed otherwise it would have packaged already. I have added __pycache__ directory explicitly now. There is no issue with python-freetype as it installs module directory and __pycache__ already gets installed. I have now fixed above issues in below updated package. Note I don't think this needs release bump hence kept same release version. Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/python-fontname.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/python-fontname-0.2.0-2.fc21.src.rpm * Rpmlint: o errors * License: MIT * Binaries: None * Spec: Clean * Content: Clean * %check test: None * Python package: Noarch * Python packaging guideline: checked * CHECKSUM(MD5) this package: 232241d94d8e3ca41bfbb373701d0d90 CHECKSUM(MD5) upstream package: 232241d94d8e3ca41bfbb373701d0d90 ======== APPROVED Thanks for this package review. New Package SCM Request ======================= Package Name: python-fontname Short Description: A lib for guessing font name Upstream URL: https://github.com/Asvel/fontname Owners: pnemade Branches: f19 f20 f21 el6 epel7 Git done (by process-git-requests). See http://pkgs.fedoraproject.org/cgit/python-fontname.git , it says "No repositories found". Git done (by process-git-requests). python-fontname-0.2.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-fontname-0.2.0-2.fc21 python-fontname-0.2.0-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-fontname-0.2.0-2.el7 python-fontname-0.2.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-fontname-0.2.0-2.el6 python-fontname-0.2.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-fontname-0.2.0-2.fc20 python-fontname-0.2.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-fontname-0.2.0-2.fc19 python-fontname-0.2.0-2.el6 has been pushed to the Fedora EPEL 6 testing repository. python-fontname-0.2.0-2.fc21 has been pushed to the Fedora 21 stable repository. python-fontname-0.2.0-2.fc19 has been pushed to the Fedora 19 stable repository. python-fontname-0.2.0-2.fc20 has been pushed to the Fedora 20 stable repository. python-fontname-0.2.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. python-fontname-0.2.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository. |