Bug 1147049
| Summary: | Passing empty values to katello-installer proxy settings creates invalid JSON | ||
|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | David Gurtner <dgurtner> |
| Component: | Installation | Assignee: | Eric Helms <ehelms> |
| Status: | CLOSED ERRATA | QA Contact: | Corey Welton <cwelton> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 6.0.4 | CC: | bbuckingham, cwelton, ehelms, elavarde, erezende, sthirugn, tspeetje |
| Target Milestone: | Unspecified | Keywords: | Reopened, Triaged |
| Target Release: | Unused | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-07-27 11:22:39 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1132363 | ||
Since this issue was entered in Red Hat Bugzilla, the release flag has been set to ? to ensure that it is properly evaluated for this release. This issue has been fully addressed by - https://github.com/Katello/katello-installer/pull/84 Failed on: Satellite-6.1.0-RHEL-7-20150331.1
Steps:
1. Run katello-installer --katello-proxy-port="" --katello-proxy-url=""
2. Checked the config files
# cat /etc/pulp/server/plugins.conf.d/{yum,puppet,iso}_importer.json
{
"proxy_host": "",
"proxy_port": ,
"proxy_username": "",
"proxy_password": ""
}
{
"proxy_host": "",
"proxy_port": ,
"proxy_username": "",
"proxy_password": ""
}
{
"proxy_host": "",
"proxy_port": ,
"proxy_username": "",
"proxy_password": ""
}
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2015:1592 Accidentally closed with 6.1.1 errata *** Bug 1278085 has been marked as a duplicate of this bug. *** POSSIBLY Verified in Snap 16:
[root@rhsm-qe-3 ~]# cat /etc/pulp/server/plugins.conf.d/{yum,puppet,iso}_importer.json
{
"proxy_host": null,
"proxy_port": null,
"proxy_username": "admin",
"proxy_password": "password"
}
{
"proxy_host": null,
"proxy_port": null,
"proxy_username": "admin",
"proxy_password": "password"
}
{
"proxy_host": null,
"proxy_port": null,
"proxy_username": "admin",
"proxy_password": "password"
}
Should we be clearing username/password if proxy settings themselves are cleared?
To clarify, does having user/password set affect things if there are no values otherwise for host and port? Tested and even if the user/passwd remain, sync continues to work. That said, there is no reason I can think of to keep user/passwd around if proxy and port are gone. Will write up a separate RFE for removal. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1501 |
Description of problem: Running katello-installer --katello-proxy-port="" generates broken Pulp Plugins files under /etc/pulp/server/plugins.conf.d/{yum,puppet,iso}_importer.json The Files will contain the following line: "proxy_port": , instead of "proxy_port": "", This prevents celeryd workers from starting. Version-Release number of selected component (if applicable): How reproducible: always Steps to Reproduce: 1. katello-installer --katello-proxy-port="" --katello-proxy-url="" Actual results: /etc/pulp/server/plugins.conf.d/{yum,puppet,iso}_importer.json Contain the line "proxy_port": , Expected results: "proxy_port": NULL, Additional info: Removing the values from answer file or passing NULL works.