Bug 1147079
| Summary: | [abrt] shotwell: __strcat_sse2_unaligned(): shotwell-video-thumbnailer killed by SIGSEGV | ||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Glenn Johnson <glennjohnson57> | ||||||||||||||||||||||||||||||||
| Component: | shotwell | Assignee: | Matthias Clasen <mclasen> | ||||||||||||||||||||||||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||||||||||||||||||||||||
| Severity: | unspecified | Docs Contact: | |||||||||||||||||||||||||||||||||
| Priority: | unspecified | ||||||||||||||||||||||||||||||||||
| Version: | 21 | CC: | alst2821, bigant, bruno, code, dhansen, dyocum, jan.public, jon.ingason, laufor, leucir, mariolinux, martin, maurygls, mclasen, metherid, michel, mnovotny, nanopqr, pbrobinson, rds, redhat-bugzilla, richard_maxime, RIKINET71, ruben.fastenau, r.weyland, sly, spoyarek, surkum, svc-bugzilla.redhat.com, tadp, thomas.jethan, thomas.moschny, twaugh, vincent.aaron | ||||||||||||||||||||||||||||||||
| Target Milestone: | --- | ||||||||||||||||||||||||||||||||||
| Target Release: | --- | ||||||||||||||||||||||||||||||||||
| Hardware: | x86_64 | ||||||||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||||||||
| URL: | https://retrace.fedoraproject.org/faf/reports/bthash/e329a1b51b92a6a5c3d63eaa4a05c4bab1dddc56 | ||||||||||||||||||||||||||||||||||
| Whiteboard: | abrt_hash:0358b98cb69172c354d972c1ca8cf718814dfbf3 | ||||||||||||||||||||||||||||||||||
| Fixed In Version: | shotwell-0.20.2-3.fc21 | Doc Type: | Bug Fix | ||||||||||||||||||||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||||||||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||||||||||||||||||||
| Last Closed: | 2015-06-23 09:09:04 UTC | Type: | --- | ||||||||||||||||||||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||||||||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||||||||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||||||||||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||||||||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||||||||||||||||||||
| Embargoed: | |||||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||||
|
Description
Glenn Johnson
2014-09-26 20:23:27 UTC
Created attachment 941704 [details]
File: backtrace
Created attachment 941705 [details]
File: cgroup
Created attachment 941706 [details]
File: core_backtrace
Created attachment 941707 [details]
File: dso_list
Created attachment 941708 [details]
File: environ
Created attachment 941709 [details]
File: exploitable
Created attachment 941710 [details]
File: limits
Created attachment 941711 [details]
File: maps
Created attachment 941712 [details]
File: open_fds
Created attachment 941713 [details]
File: proc_pid_status
Created attachment 941714 [details]
File: var_log_messages
This happened right after I started an import from a camera SD card. I experience this failure too, after importing from SD card in Shotwell. I've experienced this bug while importing from my home folder. Upstream have fixed this problem. I tested the rpm with upstream fixes as prepared for Fedora 22 (0.22.0-4.fc22) https://apps.fedoraproject.org/packages/shotwell/builds/ The source rpm is copied at this location https://www.dropbox.com/s/8zvzipm731jkb6u/shotwell-0.22.0-4.fc21.src.rpm (In reply to r_mercado from comment #15) > Upstream have fixed this problem. Got a link to the patch(es) needed so we can push this fix? (In reply to Peter Robinson from comment #16) > Got a link to the patch(es) needed so we can push this fix? No. I don't have a link to the patches. Upstream have it in a git repository. This bug is moot, since an upgrade to Fedora 22 will upgrade from shotwell-0.19 to shotwell-0.22 pulling in the fixes. (In reply to r_mercado from comment #17) > (In reply to Peter Robinson from comment #16) > > Got a link to the patch(es) needed so we can push this fix? > > No. I don't have a link to the patches. Upstream have it in a git repository. Do you have details of the upstream commit then? > This bug is moot, since an upgrade to Fedora 22 will upgrade from > shotwell-0.19 to shotwell-0.22 pulling in the fixes. No it's not moot, this is a bug against F-21 which has 7 months more support and there are people that are clearly hitting this that might not be ready or able to move straight to F-22. Created attachment 1032521 [details] patches to upgrade from shotwell 0.20 to 0.22 The location of the repository is git://git.gnome.org/shotwell I downloaded the whole repo and compared the output of versions 0.22 (5e53cc99066516f6d30669866d0516e937a28578) and 0.20.2 (6a5194e2f4bd99ce18d169f2212399c8ec041437) The result is attached in file shotwell-upgrade-0.20-to-0.22.patch I also verified that the git repos match the sources in the .src.rpm files for shotwell at https://dl.fedoraproject.org/pub/fedora/linux/updates/22/SRPMS and https://dl.fedoraproject.org/pub/fedora/linux/updates/21/SRPMS The notes in the NEWS file explain the changes Shotwell 0.22.0 - 23 March 2015 ------------------------------- * Improved metadata support for Facebook upload (#742163) * Saved search now properly supports text is-set, not-set (#743924, #743923) * Import title, exposure time when available * User interface improvements (#744291, #719284, more) * Sort photos by filename (#717878) * Updated translations Shotwell 0.21.0 - 2 February 2015 --------------------------------- * User interface refresh (#742326, #742443) * Fix Shotwell Viewer .desktop file (#743799) * Natural sorting of photo titles (#717960) * Improved video thumbnailer (#739396, #741821) * Updated translations I am sorry, but we will not update Shotwell to 0.22 in Fedora 21. That is simply against Fedora policies. We did this once, and got a lot of bad feedback. What we can do though (and I think this is what Peter was asking for) is to go through the upstream commits, try to find commits fixing the issue at hand, and cherry-pick them onto the current package. If I find time, I can try to do that, unless someone else beats me. Meanwhile, you can try to use builds from my side-repo: http://copr.fedoraproject.org/coprs/thm/shotwell/ It should have a Shotwell 0.22 build for Fedora 21. Created attachment 1033010 [details]
upstream commit 22902f6
Created attachment 1033011 [details]
upstream commit 6a35d6
Created attachment 1033012 [details]
upstream commit 4d088d7b
(In reply to Thomas Moschny from comment #20) > I am sorry, but we will not update Shotwell to 0.22 in Fedora 21. > okay. I tracked down the gnome bugzilla entries https://bugzilla.gnome.org/ * Improved video thumbnailer (#739396, #741821) bugzilla 739396: Jim Nelson 2014-12-30 22:07:58 UTC mentions commit hash: 22902f6c831a7bc2f4a228f04c394421137c4061 also refers to an old bug 718989 fixed with commit hash: 4d088d7bfd5dcf82d8f301667b3856764e7489ad bugzilla 741821: Jim Nelson 2014-12-22 21:24:47 UTC commit hash: 6a35d6 The chrogit checkout shotwell-0.20.2nological order of the relevant commits is 22902f6, 6a35d6 and 4d088d7b the steps below show my test of the generation of a video thumbnail that previously failed git checkout shotwell-0.20.2 git checkout -b fedora21-fix git cherry-pick 22902f6 6a35d6 4d088d7b ./configure make ./thumbnailer/shotwell-video-thumbnailer /home/polka/Pictures/2010/07/18/DSCF2919.AVI > thumb.png I attach the upstream commits corresponding to 22902f6, 6a35d6 and 4d088d7b. The file names are 01-commit-49507e4 02-commit-64b6ab8 03-commit-ca533f9 Apologies. In comment 24, the section "The chrogit checkout shotwell-0.20.2nological order of the relevant commits is 22902f6, 6a35d6 and 4d088d7b" should read The chronological order of the relevant commits is 22902f6, 6a35d6 and 4d088d7b (In reply to Thomas Moschny from comment #20) > I am sorry, but we will not update Shotwell to 0.22 in Fedora 21. Not asking for that, asking for a particular patch set to be pulled into 0.20 to fix this specific crash. > That is simply against Fedora policies. We did this once, and got a lot of > bad feedback. > > What we can do though (and I think this is what Peter was asking for) is to > go through the upstream commits, try to find commits fixing the issue at > hand, and cherry-pick them onto the current package. Yes. That's exactly what I want :-) Hello I am posting because I uploaded two things related to this bug: An updated spec file including the patches I posted last month. https://kiso49j.fedorapeople.org/shotwell.spec A source rpm I built on my fedora 22 machine https://kiso49j.fedorapeople.org/shotwell-0.20.2-2.fc22.src.rpm I will attempt in the next few days to get copr to generate a repository as in comment #20 Thanks. shotwell-0.20.2-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/shotwell-0.20.2-3.fc21 Package shotwell-0.20.2-3.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing shotwell-0.20.2-3.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-9836/shotwell-0.20.2-3.fc21 then log in and leave karma (feedback). shotwell-0.20.2-3.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. |