Bug 1147486

Summary:	AFR : Self-heal daemon incorrectly retries healing
Product:	[Community] GlusterFS	Reporter:	Anuradha <atalur>
Component:	replicate	Assignee:	Anuradha <atalur>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.6.0	CC:	bugs, smohan
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.6.1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1146812	Environment:
Last Closed:	2014-11-10 15:13:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1146812
Bug Blocks:

Description Anuradha 2014-09-29 11:30:12 UTC

+++ This bug was initially created as a clone of Bug #1146812 +++

Description of problem:

self-heal daemon index healer loops and retries healing even though heal fails, instead of exiting.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2014-09-26 06:10:04 EDT ---

REVIEW: http://review.gluster.org/8868 (cluster/afr : Fix incorrect looping of index healer) posted (#1) for review on master by Anuradha Talur (atalur)

--- Additional comment from Anand Avati on 2014-09-29 02:46:09 EDT ---

REVIEW: http://review.gluster.org/8868 (cluster/afr : Fix incorrect looping of index healer) posted (#2) for review on master by Anuradha Talur (atalur)

--- Additional comment from Anand Avati on 2014-09-29 05:58:37 EDT ---

COMMIT: http://review.gluster.org/8868 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 3ba5f1d38d58e72d562f6d19498bed00fb2727bc
Author: Anuradha <atalur>
Date:   Fri Sep 26 14:18:05 2014 +0530

    cluster/afr : Fix incorrect looping of index healer
    
    Sending appropriate return value from afr_selfheal()
    fixes the issue.
    
    Credits : Krutika Dhananjay and Pranith Kumar.
    
    Change-Id: I01dbd49476f6bfbd02028fdde1f60cc0324a1e39
    BUG: 1146812
    Signed-off-by: Anuradha <atalur>
    Reviewed-on: http://review.gluster.org/8868
    Reviewed-by: Krutika Dhananjay <kdhananj>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>

Comment 1 Anand Avati 2014-09-29 11:39:57 UTC

REVIEW: http://review.gluster.org/8884 (cluster/afr : Fix incorrect looping of index healer) posted (#1) for review on release-3.6 by Anuradha Talur (atalur)

Comment 2 Anand Avati 2014-09-30 06:32:20 UTC

COMMIT: http://review.gluster.org/8884 committed in release-3.6 by Vijay Bellur (vbellur) 
------
commit e06ee49ffd6c2829357f89b192f25c1f116925ff
Author: Anuradha <atalur>
Date:   Fri Sep 26 14:18:05 2014 +0530

    cluster/afr : Fix incorrect looping of index healer
    
    	Backport of: http://review.gluster.org/8868
    
    Sending appropriate return value from afr_selfheal()
    fixes the issue.
    
    Credits : Krutika Dhananjay and Pranith Kumar.
    
    Change-Id: I1dc8105078e99dbc12295ef557a407bf3d8cfec3
    BUG: 1147486
    Signed-off-by: Anuradha <atalur>
    Reviewed-on: http://review.gluster.org/8884
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Niels de Vos 2014-11-10 15:13:54 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users