Bug 1148246

Summary:	libmygpo-qt: include path for cmake and pkgconfig are wrong
Product:	[Fedora] Fedora	Reporter:	Patrick <phorgan1>
Component:	libmygpo-qt	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	20	CC:	affix, rdieter
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libmygpo-qt-1.0.8-2.fc20	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-10-08 19:14:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Patrick 2014-10-01 04:06:09 UTC

Description of problem:
After installing libmygpo-qt and libmygpo-qt-devel to build Clementine the clementine build complained that it couldn't find ApiRequest.h. Investigation showed that Mygpo-qtConfig.cmake had set(LIBMYGPO_QT_INCLUDE_DIRS "/usr/include"), and libmygpo-qt.pc has includedir=/usr/include when both should reference /usr/include/mygpo-qt since that's where ApiRequest.h is.

Version-Release number of selected component (if applicable):
libmygpo-qt.so.1.0.7

How reproducible:
Install libmygpo-qt and libmygpo-qt-devel and then try to build an ap that uses it.

Steps to Reproduce:
1.
2.
3.

Actual results:
ApiRequest.h not found for #include <ApiRequest.h>

Expected results:
ApiRequest.h found

Additional info:
Editing the file resulted in the build completing fine. Of course I could have edited the file in clementine to have #include <mygpo-qt/ApiRequest.h> and that would have worked too, but going to the site for libmygpo-qt they have instructions saying that you are _supposed_ to just used <ApiRequest.h> I figured it's their library so they should know. Otherwise building the same app on different versions of linux would require editing for each.

Comment 1 Rex Dieter 2014-10-01 09:35:42 UTC

I previously assumed rather clementine was not using the api correctly.  amarok, for example, always does
#include <mygpo-qt/ApiRequest.h>

So, we've always patched clementine to follow suit,
http://pkgs.fedoraproject.org/cgit/clementine.git/tree/clementine-mygpo.patch

Otherwise, we'll have to patch libmygpo-qt (and amarok), as you suggested.

I'll look into it more today.

Comment 2 Rex Dieter 2014-10-01 09:50:29 UTC

I think I found the problem, it's an incompatibility with between libmygpo-qt's cmake files and fedora's standard cmake macros.

Comment 3 Rex Dieter 2014-10-01 12:50:58 UTC

Patched builds underway, and upstream pull request submitted to fix the problem:
https://github.com/gpodder/libmygpo-qt/pull/6

Comment 4 Fedora Update System 2014-10-01 13:19:44 UTC

libmygpo-qt-1.0.8-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/libmygpo-qt-1.0.8-1.fc21

Comment 5 Fedora Update System 2014-10-01 13:20:15 UTC

libmygpo-qt-1.0.8-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/libmygpo-qt-1.0.8-1.fc20

Comment 6 Fedora Update System 2014-10-01 13:20:48 UTC

libmygpo-qt-1.0.8-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/libmygpo-qt-1.0.8-1.fc19

Comment 7 Fedora Update System 2014-10-03 04:02:56 UTC

Package libmygpo-qt-1.0.8-1.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing libmygpo-qt-1.0.8-1.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-12034/libmygpo-qt-1.0.8-1.fc21
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2014-10-08 19:14:21 UTC

libmygpo-qt-1.0.8-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Patrick 2014-10-09 14:57:52 UTC

(In reply to Fedora Update System from comment #8)
> libmygpo-qt-1.0.8-1.fc21 has been pushed to the Fedora 21 stable repository.
> If problems still persist, please make note of it in this bug report.

Is it ok to install it even though I'm still on 20? I'm waiting for the beta (or at least the beta freeze) this month to upgrade. Do you mind if I ask how you resolved it? All you've said is, "incompatibility with between libmygpo-qt's cmake files and fedora's standard cmake macros" which leaves me more curious than anything.

Comment 10 Rex Dieter 2014-10-09 15:05:21 UTC

You can install the build for f20:
https://admin.fedoraproject.org/updates/FEDORA-2014-12051

(currently still in updates-testing).


If you're curious what the specific fix involved, see:
https://github.com/gpodder/libmygpo-qt/pull/6

Comment 11 Fedora Update System 2014-10-19 13:19:14 UTC

libmygpo-qt-1.0.8-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2014-10-19 13:20:27 UTC

libmygpo-qt-1.0.8-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Patrick 2014-10-24 01:57:55 UTC

Thank you. I see that you changed them just as I did. I can confirm that the I can build clementine from their git repository just fine now. You are the best.