Bug 1148456
| Summary: | Review Request: golang-github-onsi-ginkgo - A Golang BDD Testing Framework | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Chaloupka <jchaloup> |
| Component: | Package Review | Assignee: | Lokesh Mandvekar <lsm5> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | lsm5, package-review |
| Target Milestone: | --- | Flags: | lsm5:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | golang-github-onsi-ginkgo-0-0.3.git17ea479.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-10-19 13:21:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jan Chaloupka
2014-10-01 13:49:02 UTC
Not sure if we want to Provide %{import_path}/integration/_fixtures*
If we're installing %{import_path}/integration, the package needs to own all subdirs in integration/
Rest looks good, but will approve once the Provides is confirmed :)
Yes, they don't have to be provided. Spec file updated, links are the same. Probably can get rid of this too:
Provides: golang(%{import_path}/integration) = %{version}-%{release}
Right, there is only integration.go, which is one line package statement. All other files are test suites. But will keep it in files section is test are always needed. Again, URLs are the same. Package approved. specfile conforms to Go packaging draft. New Package SCM Request ======================= Package Name: golang-github-onsi-ginkgo Short Description: A Golang BDD Testing Framework Upstream URL: https://github.com/onsi/ginkgo Owners: jchaloup lsm5 vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig Git done (by process-git-requests). f22 https://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20141006/1401865.html f21 https://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20141006/1401866.html f20 https://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20141006/1401868.html el6 https://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20141006/1401870.html golang-github-onsi-ginkgo-0-0.1.git90d6a47.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-onsi-ginkgo-0-0.1.git90d6a47.el6 golang-github-onsi-ginkgo-0-0.1.git90d6a47.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-onsi-ginkgo-0-0.1.git90d6a47.fc20 golang-github-onsi-ginkgo-0-0.1.git90d6a47.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-onsi-ginkgo-0-0.1.git90d6a47.fc21 golang-github-onsi-ginkgo-0-0.1.git90d6a47.el6 has been pushed to the Fedora EPEL 6 testing repository. golang-github-onsi-ginkgo-0-0.2.git90d6a47.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-onsi-ginkgo-0-0.2.git90d6a47.el6 golang-github-onsi-ginkgo-0-0.1.git90d6a47.fc20 has been pushed to the Fedora 20 stable repository. golang-github-onsi-ginkgo-0-0.3.git17ea479.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-onsi-ginkgo-0-0.3.git17ea479.fc20 golang-github-onsi-ginkgo-0-0.3.git17ea479.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-onsi-ginkgo-0-0.3.git17ea479.fc21 golang-github-onsi-ginkgo-0-0.3.git17ea479.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-onsi-ginkgo-0-0.3.git17ea479.el6 golang-github-onsi-ginkgo-0-0.3.git17ea479.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. golang-github-onsi-ginkgo-0-0.3.git17ea479.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. golang-github-onsi-ginkgo-0-0.3.git17ea479.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |