Bug 1148995

Summary: cups-files.conf contains errors
Product: [Fedora] Fedora Reporter: Onyeibo Oku <twohotis>
Component: cupsAssignee: Tim Waugh <twaugh>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: urgent Docs Contact:
Priority: high    
Version: rawhideCC: bitlord0xff, jpopelka, robatino, twaugh
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: cups-2.0.0-3.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-10-03 12:14:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
cups-files.conf uploaded to fpaste.o none

Description Onyeibo Oku 2014-10-02 20:56:38 UTC
Description of problem:
cupsd is Unable to read "/etc/cups/cups-files.conf" due to errors

Version-Release number of selected component (if applicable):
cups-2.0.0-1.fc22.x86_64

How reproducible:
cupsd -t says its still there

Steps to Reproduce:
1. update from cups-1:1.7.5-7.fc22.x86_64
2. during cleanup, you should get a message
3. cupsd[5808]: Unable to read "/etc/cups/cups-files.conf" due to errors

Actual results:
cupsd[5808]: Unable to read "/etc/cups/cups-files.conf" due to errors
... or something similar

Expected results:
a smooth transition to version 2.0

Additional info:

Comment 1 Jiri Popelka 2014-10-03 10:54:14 UTC
(In reply to Onyeibo from comment #0)
> 2. during cleanup, you should get a message

what cleanup ?

> 3. cupsd[5808]: Unable to read "/etc/cups/cups-files.conf" due to errors

I don't see any significant change in cups-files.conf between 1.7.5 and 2.0.0.
Can you attach yours ?

Comment 2 Branko Grubić 2014-10-03 11:11:27 UTC
I asked him to file a bug, if something is wrong, I'm one to blame. 
While "we" wait for him to respond, I can tell  this shortly what "we" discussed on #fedora-qa and #fedora-devel.

He saw the message 
cupsd[5808]: Unable to read "/etc/cups/cups-files.conf" due to errors
while updating packages, I think during cleanup phase, so he asked if something is wrong with this. I asked him to check/verify the package with rpm
rpm -V cups, and this was the result
<twohot>	and rpm -V cups-2.0.0-1.fc22.x86_64 yeilds ".M.......  c /etc/cups/subscriptions.conf"
so nothing related to 'cups-files.conf', I don't know much about cups, but executed 'cupsd --help' and saw '-t' option to test config files, and asked him to try and see if cupsd complains about config files 

<bitlord>	twohot, what   cupsd -t    says  it should test config files
<twohot>	"/etc/cups/cups-files.conf" contains errors.

So I looked at changes, and how it is packaged, and thought maybe some config parameters/syntax has changed from 1.7.x -> 2.x, and saw a lot of patches in package git tree (I didn't check all of them if they patch .conf files), so I thought there is something wrong with packaging. I also asked him later to check if he changed that file before, and if there is a .rpmnew available, and I think he said he didn't touch it before, so it should be replaced automatically I think?

Comment 3 Branko Grubić 2014-10-03 11:16:00 UTC
Created attachment 943703 [details]
cups-files.conf uploaded to fpaste.o

This is from fpaste.org what he uploaded, if that helps (from my irc log)

Comment 4 Jiri Popelka 2014-10-03 11:23:42 UTC
I see the problem (PageLogFormat directive) now, thanks.

Comment 7 Jiri Popelka 2014-10-03 11:34:40 UTC
For the reporter:
Removing the last line (PageLogFormat) from cups-files.conf should fix your problem.

Comment 8 Jiri Popelka 2014-10-03 12:14:34 UTC
Should be fixed in cups-2.0.0-3.fc22

http://pkgs.fedoraproject.org/cgit/cups.git/commit/?id=e469187dca2ac22ebc0348fce8796525b1fff9f6