Bug 1149098

Summary: Grammar issue, "unregister" not a word.
Product: Red Hat Enterprise Linux 6 Reporter: Pete Harvey <pete>
Component: subscription-managerAssignee: Chris "Ceiu" Rog <crog>
Status: CLOSED WONTFIX QA Contact: John Sefler <jsefler>
Severity: low Docs Contact:
Priority: unspecified    
Version: 6.7CC: alikins, crog, dgoodwin
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-05-29 17:40:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1209535    

Description Pete Harvey 2014-10-03 08:36:14 UTC
Description of problem:

Use of the term "unregister" is bogus, it's not an English word. Suggest replacing with grammatically correct "deregister". 

Version-Release number of selected component (if applicable):
subscription-manager-1.1.23-1.el6.x86_64

How reproducible:
Always.

Steps to Reproduce:
1. Subscribe system using subscription-manager.
2. Attempt to remove subscription.

Actual results:
[root@rhelhost ~]# subscription-manager unregister
System has been un-registered.

Expected results:
[root@rhelhost ~]# subscription-manager deregister
System has been deregistered.

Comment 2 Bryan Kearney 2014-11-03 19:55:02 UTC
Moving bugs to 6.7

Comment 3 John Sefler 2015-02-05 20:41:09 UTC
Here is the current list of all instances of "unregister" in the extracted msgids

[root@jsefler-os7 ~]# rpm -q subscription-manager
subscription-manager-1.13.19-1.el7.x86_64

[root@jsefler-os7 ~]# msgunfmt --no-wrap /usr/share/locale/fr/LC_MESSAGES/rhsm.mo | grep -i "unregister"
msgid "<b>Are you sure you want to unregister?</b>"
msgid "<b>Errors were encountered during unregister.</b>"
msgid "Preparing to unregister system from legacy server..."
msgid "System has been unregistered."
msgid "System successfully unregistered from legacy server."
msgid "The system with UUID %s has been unregistered"
msgid "To learn how to unregister from either service please consult this Knowledge Base Article: https://access.redhat.com/kb/docs/DOC-45563"
msgid "Unable to unregister system from legacy server.  "
msgid "Unregister the system from the server"
msgid "Unregister this system from the Customer Portal or another subscription management service"
msgid "_Unregister"
[root@jsefler-os7 ~]#

Comment 4 John Sefler 2015-02-05 21:15:47 UTC
"reregister" is not recognized by dictionary.com in the following msgids

[root@jsefler-os7 ~]# msgunfmt --no-wrap /usr/share/locale/fr/LC_MESSAGES/rhsm.mo | grep -i "reregister"
msgid "System certificates corrupted. Please reregister."
[root@jsefler-os7 ~]#

Comment 5 John Sefler 2015-02-05 21:56:05 UTC
[root@jsefler-os7 ~]# msgunfmt --no-wrap /usr/share/locale/fr/LC_MESSAGES/rhsm.mo | grep -i "unregistration"
msgid "Did not receive a completed unregistration message from legacy server for system %s."


"unregistration" is not a word

Comment 6 John Sefler 2015-02-09 17:40:02 UTC
If "unregister" is changed in subscription-manager, then the following msgid should also be fixed in candlepin...

[root@jsefler-os-candlepin po]# grep "unregister" keys.pot 
msgid "Cannot unregister {0} {1} because: {2}"

Comment 7 John Sefler 2015-02-09 17:46:12 UTC
[root@jsefler-os-candlepin po]# grep "json" keys.pot 
msgid "Guest ID in json \"{0}\" does not match path guest ID \"{1}\""


"json" should probably be written as "JSON"

Comment 8 John Sefler 2015-02-09 17:47:36 UTC
[root@jsefler-os-candlepin po]# grep "ActivationKey" keys.pot 
msgid "ActivationKey with id {0} could not be found."


"ActivationKey" should be "Activation Key"

Comment 9 John Sefler 2015-02-13 21:53:27 UTC
If "unregister" is changed in subscription-manager, then the following lines should be changed in the man page for rhn-migrate-classic-to-rhsm...

[root@jsefler-os7 ~]# man rhn-migrate-classic-to-rhsm | grep -i "unregister"
              5. Unregister from Red Hat Network Classic.
       Preparing to unregister system from legacy server...
       System successfully unregistered from legacy server.

Comment 10 Adrian Likins 2015-04-21 13:35:04 UTC
I poked "Red Hat Word Nerds"/#wordnerds about this, and they suggested staying with "unregister".


I also don't think it's worth changing even if it wasn't the preferred term.