Bug 1149126
| Summary: | strace-4.9 RPM missing definitions of a lot of ioctls that in fact are in Git repository | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lrintel> | ||||
| Component: | strace | Assignee: | Dmitry V. Levin <ldv> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 21 | CC: | dvlasenk, ldv, lrintel, schwab | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | strace-4.9-3.fc21 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-11-10 06:37:25 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Ping? Anything I can do to help move this forward for F21? Would you mind if I did the update myself? I'd like to have a proper fix for this rather than an interim solution. Could you please check what kind of linux/ioctlent.h.in is produced after invoking "./make-dist v4.9" in your environment? Hi, (In reply to Dmitry V. Levin from comment #2) > I'd like to have a proper fix for this rather than an interim solution. Well, with beta freeze approaching, there's probably a good idea to have any kind of fix; especially when things look fine in Git, just the past release distribution seems broken. > Could you please check what kind of linux/ioctlent.h.in is produced after > invoking "./make-dist v4.9" in your environment? Sure, I'm quite unsure whether we're on the same page here though -- this does not seem to have much with my environment, more like the environment the distribution tarball was generated in. However, when I run "./make-dist v4.9" from a Git clone, it does not change anything. "git diff" does not print a single line. Thank you (In reply to Lubomir Rintel from comment #3) > > Could you please check what kind of linux/ioctlent.h.in is produced after > > invoking "./make-dist v4.9" in your environment? > > Sure, I'm quite unsure whether we're on the same page here though -- this > does not seem to have much with my environment, more like the environment > the distribution tarball was generated in. > > However, when I run "./make-dist v4.9" from a Git clone, it does not change > anything. "git diff" does not print a single line. "./make-dist v4.9" from strace.git produces a new strace-4.9.tar.xz file, normally it doesn't change anything else. (In reply to Dmitry V. Levin from comment #4) > (In reply to Lubomir Rintel from comment #3) > > > Could you please check what kind of linux/ioctlent.h.in is produced after > > > invoking "./make-dist v4.9" in your environment? > > > > Sure, I'm quite unsure whether we're on the same page here though -- this > > does not seem to have much with my environment, more like the environment > > the distribution tarball was generated in. > > > > However, when I run "./make-dist v4.9" from a Git clone, it does not change > > anything. "git diff" does not print a single line. > > "./make-dist v4.9" from strace.git produces a new strace-4.9.tar.xz file, > normally it doesn't change anything else. Well, the tarball obviously is different; maybe the make-dist was run from a dirty checkout? make-dist doesn't operate with checkouts, it operates with commits. So what was the difference? Shouldn't we move this discussion to strace-devel mailing list, so that other people could comment? (In reply to Dmitry V. Levin from comment #6) > make-dist doesn't operate with checkouts, it operates with commits. > So what was the difference? Oh, I see now. Sorry. make-dist fails the date check. However, commenting the news-check out, it succeeds. It indeed produces a broken (= missing definitions) distribution. > Shouldn't we move this discussion to strace-devel mailing list, so that > other people could comment? Yeah, sounds wise. I've sent a follow-up message to the list, with a patch that fixes the problem for me. Please have a look and adjust/apply it as you wish. (While at that, on a somehow unrelated note, recently I've resent another patch to the list, after some years of non-response; I'm wondering if you could take a look too) I'd be very thankful if you could fix the package any way you like before the final freeze though. Thank you. Ping? An upstream fix for "make dist" won't fix this bug until a fixed tarball is released. Lubomir, as time is pressing, I certainly wouldn't mind if you updated the package. strace-4.9-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/strace-4.9-3.fc21 Package strace-4.9-3.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing strace-4.9-3.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-14195/strace-4.9-3.fc21 then log in and leave karma (feedback). strace-4.9-3.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 943672 [details] Differencies between SCM and dsitribution Description of problem: linux/ioctlent.h.in from the RPM is a lot shorter than one from Git. Quick check is grep RFCOMMCREATEDEV linux/ioctlent.h.in. I'm attaching a patch that I'm currently using that brings them in sync (might not be an useful fix, but provides a good overview).